Git Mailing List Archive mirror
 help / color / mirror / Atom feed
* [PATCH] t2015-checkout-unborn.sh: changes the style for cd
@ 2023-02-18 19:21 ashutosh.pandeyhlr007
  2023-02-21 20:01 ` Junio C Hamano
  2023-02-21 20:04 ` Junio C Hamano
  0 siblings, 2 replies; 3+ messages in thread
From: ashutosh.pandeyhlr007 @ 2023-02-18 19:21 UTC (permalink / raw)
  To: git; +Cc: Ashutosh Pandey

From: Ashutosh Pandey <ashutosh.pandeyhlr007@gmail.com>

the `cd` followed the old style which wasn't consistent with the rest of
the test suite, so this commit makes it consistent with the current
style of the test suite for `cd` in  subshell.

Signed-off-by: Ashutosh Pandey <ashutosh.pandeyhlr007@gmail.com>
---
this is my first time contributing to git I want to participate in 
this year's GSoC and I'm looking for some microprojects the ones
that are listed on the website are mostly done so if anyone can 
suggest some beginners level microprojects that would be great.

 t/t2015-checkout-unborn.sh | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/t/t2015-checkout-unborn.sh b/t/t2015-checkout-unborn.sh
index 9425aae639..fdc4149f15 100755
--- a/t/t2015-checkout-unborn.sh
+++ b/t/t2015-checkout-unborn.sh
@@ -9,11 +9,12 @@ TEST_PASSES_SANITIZE_LEAK=true
 
 test_expect_success 'setup' '
 	mkdir parent &&
-	(cd parent &&
-	 git init &&
-	 echo content >file &&
-	 git add file &&
-	 git commit -m base
+	(
+		cd parent &&
+	 	git init &&
+	 	echo content >file &&
+	 	git add file &&
+	 	git commit -m base
 	) &&
 	git fetch parent main:origin
 '

base-commit: d9d677b2d8cc5f70499db04e633ba7a400f64cbf
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] t2015-checkout-unborn.sh: changes the style for cd
  2023-02-18 19:21 [PATCH] t2015-checkout-unborn.sh: changes the style for cd ashutosh.pandeyhlr007
@ 2023-02-21 20:01 ` Junio C Hamano
  2023-02-21 20:04 ` Junio C Hamano
  1 sibling, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2023-02-21 20:01 UTC (permalink / raw)
  To: ashutosh.pandeyhlr007; +Cc: git

ashutosh.pandeyhlr007@gmail.com writes:

> From: Ashutosh Pandey <ashutosh.pandeyhlr007@gmail.com>
>
> the `cd` followed the old style which wasn't consistent with the rest of
> the test suite, so this commit makes it consistent with the current
> style of the test suite for `cd` in  subshell.
>
> Signed-off-by: Ashutosh Pandey <ashutosh.pandeyhlr007@gmail.com>
> ---
> this is my first time contributing to git I want to participate in 
> this year's GSoC and I'm looking for some microprojects the ones
> that are listed on the website are mostly done so if anyone can 
> suggest some beginners level microprojects that would be great.
>
>  t/t2015-checkout-unborn.sh | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/t/t2015-checkout-unborn.sh b/t/t2015-checkout-unborn.sh
> index 9425aae639..fdc4149f15 100755
> --- a/t/t2015-checkout-unborn.sh
> +++ b/t/t2015-checkout-unborn.sh
> @@ -9,11 +9,12 @@ TEST_PASSES_SANITIZE_LEAK=true
>  
>  test_expect_success 'setup' '
>  	mkdir parent &&
> -	(cd parent &&
> -	 git init &&
> -	 echo content >file &&
> -	 git add file &&
> -	 git commit -m base
> +	(
> +		cd parent &&
> +	 	git init &&
> +	 	echo content >file &&
> +	 	git add file &&
> +	 	git commit -m base
>  	) &&
>  	git fetch parent main:origin
>  '

OK.  This makes it siimlar to the last test in the same t2015 script
that uses this "more recent" style.

Looks good.

Thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] t2015-checkout-unborn.sh: changes the style for cd
  2023-02-18 19:21 [PATCH] t2015-checkout-unborn.sh: changes the style for cd ashutosh.pandeyhlr007
  2023-02-21 20:01 ` Junio C Hamano
@ 2023-02-21 20:04 ` Junio C Hamano
  1 sibling, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2023-02-21 20:04 UTC (permalink / raw)
  To: ashutosh.pandeyhlr007; +Cc: git

ashutosh.pandeyhlr007@gmail.com writes:

> +	(
> +		cd parent &&
> +	 	git init &&
> +	 	echo content >file &&
> +	 	git add file &&
> +	 	git commit -m base

These four lines begin with "HT SP HT"; the space between the
horizontal tabs should be removed.

No need to resend, as "git am --whitespace=fix" already corrected
them.

Thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-02-21 20:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-18 19:21 [PATCH] t2015-checkout-unborn.sh: changes the style for cd ashutosh.pandeyhlr007
2023-02-21 20:01 ` Junio C Hamano
2023-02-21 20:04 ` Junio C Hamano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).