From: Junio C Hamano <gitster@pobox.com>
To: "Chris. Webster via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, "Chris. Webster" <chris@webstech.net>
Subject: Re: [PATCH 2/2] Improve check-whitespace output
Date: Fri, 16 Dec 2022 19:13:15 +0900 [thread overview]
Message-ID: <xmqqh6xvmzb8.fsf@gitster.g> (raw)
In-Reply-To: <cdc2b1aae81f8c37b4e71cb3e0e382cf82de2272.1671179520.git.gitgitgadget@gmail.com> (Chris. Webster via GitGitGadget's message of "Fri, 16 Dec 2022 08:32:00 +0000")
"Chris. Webster via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: "Chris. Webster" <chris@webstech.net>
> Subject: Re: [PATCH 2/2] Improve check-whitespace output
The same comment about specificity of the improvements applies to
this one, too. Also, I forgot to point out that our usual commit
title takes the form of "<area>: <description>", e.g.
Subject: [PATCH 2/2] ci: show $X in check.whitespace output
where "show $X" is meant to be a more concrete phrase than "improve"
what the change is about and how it improves the output.
> + echo "Run these commands to correct the problem:" >>$GITHUB_STEP_SUMMARY
> + echo "1. \`git rebase --whitespace=fix ${goodparent}\`" >>$GITHUB_STEP_SUMMARY
> + echo "1. \`git push --force\`" >>$GITHUB_STEP_SUMMARY
It's a bit curious to see two "1." and not "1." followed by "2."
here. Is this meant to be processed by markdown or something so we
do not have to do the numbering ourselves, or something?
> + echo " " >>$GITHUB_STEP_SUMMARY
> + echo "Errors:" >>$GITHUB_STEP_SUMMARY
> for i in "${problems[@]}"
> do
> echo "${i}" >>$GITHUB_STEP_SUMMARY
Thanks.
next prev parent reply other threads:[~2022-12-16 10:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 8:31 [PATCH 0/2] Make check-whitespace failures more helpful Chris. Webster via GitGitGadget
2022-12-16 8:31 ` [PATCH 1/2] Make `check-whitespace` " Chris. Webster via GitGitGadget
2022-12-16 10:06 ` Junio C Hamano
2022-12-20 0:30 ` Chris Webster
2022-12-20 1:36 ` Junio C Hamano
2022-12-20 5:50 ` Chris Webster
2022-12-16 8:32 ` [PATCH 2/2] Improve check-whitespace output Chris. Webster via GitGitGadget
2022-12-16 10:13 ` Junio C Hamano [this message]
2022-12-20 0:33 ` Chris Webster
2022-12-20 0:35 ` [PATCH v2 0/3] Make check-whitespace failures more helpful Chris. Webster via GitGitGadget
2022-12-20 0:35 ` [PATCH v2 1/3] ci (check-whitespace): suggest fixes for errors Chris. Webster via GitGitGadget
2022-12-20 7:34 ` Đoàn Trần Công Danh
2022-12-20 19:55 ` Chris Webster
2022-12-21 1:53 ` Đoàn Trần Công Danh
2022-12-21 6:08 ` Chris Webster
2022-12-21 13:46 ` Đoàn Trần Công Danh
2022-12-20 0:35 ` [PATCH v2 2/3] ci (check-whitespace): add links to job output Chris. Webster via GitGitGadget
2022-12-20 0:35 ` [PATCH v2 3/3] ci (check-whitespace): move to actions/checkout@v3 Chris. Webster via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh6xvmzb8.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=chris@webstech.net \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).