From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, "Rafael Dulfer" <rafael@dulfer.be>,
"Andrei Rybak" <rybak.a.v@gmail.com>,
"Rafael Dulfer" <rafael.dulfer@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH v2] rev-list: clarify git-log default date format
Date: Wed, 15 Feb 2023 18:58:33 -0800 [thread overview]
Message-ID: <xmqqfsb6tixy.fsf@gitster.g> (raw)
In-Reply-To: <Y+2R2qIVQG9hJpEA@coredump.intra.peff.net> (Jeff King's message of "Wed, 15 Feb 2023 21:15:54 -0500")
Jeff King <peff@peff.net> writes:
> On Wed, Feb 15, 2023 at 04:42:25PM -0800, Junio C Hamano wrote:
>
>> The documentation mistakenly said that the default format was
>> similar to RFC 2822 format and tried to specify it by enumerating
>> differences, which had two problems:
>>
>> * There are some more differences from the 2822 format that are not
>> mentioned; worse yet
>>
>> * The default format is not modeled after RFC 2822 format at all.
>> As can be seen in f80cd783 (date.c: add "show_date()" function.,
>> 2005-05-06), it is a derivative of ctime(3) format.
>>
>> Stop saying that it is similar to RFC 2822, and rewrite the
>> description to explain the format without requiring the reader to
>> know any other format.
>>
>> Signed-off-by: Junio C Hamano <gitster@pobox.com>
>> ---
>> * The discussion stalled and the topic was left in limbo for a few
>> weeks. Let's attempt to reboot it instead of silently waiting
>> for a rerolled version from the original author.
>
> Thanks for keeping this moving. The proposed text looks great to me.
Thanks, but the formatting is broken, and needs a line with "--" on
it at the end. What I will queue on 'seen' already has the
correction.
next prev parent reply other threads:[~2023-02-16 2:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 15:57 [PATCH] rev-list: clarify git-log default date format Rafael Dulfer
2023-02-01 18:19 ` Junio C Hamano
2023-02-01 22:28 ` Ævar Arnfjörð Bjarmason
2023-02-01 22:58 ` Junio C Hamano
2023-02-02 11:37 ` Rafael Dulfer
2023-02-02 16:17 ` Junio C Hamano
2023-02-02 16:53 ` Junio C Hamano
2023-02-16 0:42 ` [PATCH v2] " Junio C Hamano
2023-02-16 2:15 ` Jeff King
2023-02-16 2:58 ` Junio C Hamano [this message]
2023-02-16 16:29 ` [PATCH v3] " Junio C Hamano
2023-02-16 17:24 ` Jeff King
2023-02-01 22:47 ` [PATCH] " Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfsb6tixy.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=rafael.dulfer@gmail.com \
--cc=rafael@dulfer.be \
--cc=rybak.a.v@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).