From: Junio C Hamano <gitster@pobox.com>
To: Doug Anderson <dianders@chromium.org>
Cc: Emily Shaffer <nasamuffin@google.com>,
Git List <git@vger.kernel.org>,
michael.strawbridge@amd.com
Subject: Re: bug report: cover letter is inheriting last patch's message ID with send-email
Date: Wed, 17 May 2023 13:04:35 -0700 [thread overview]
Message-ID: <xmqqfs7upvvw.fsf@gitster.g> (raw)
In-Reply-To: <CAD=FV=XnzFrczC1dvsHYgNabZMhC7-K1uG8=MH20qNE25o0CEA@mail.gmail.com> (Doug Anderson's message of "Wed, 17 May 2023 12:24:35 -0700")
Doug Anderson <dianders@chromium.org> writes:
> Yes. It exists in all of the patches except 0000-cover-letter.patch.
> ...but when the mail gets actually sent the cover letter and last
> patch (0006 in the case I reported) end up sharing the same Change ID.
> With older versions of git send-email the cover letter would get an
> auto-generated Message-Id.
Yeah, I think the patch I sent in the thread should help; I'd
appreciate it if you folks can test and verify.
>> I suspect that
>> is the root cause of the problem; if 000[1-6]-*.patch already has
>> their own Message-ID: because --thread is used when running
>> git-format-patch, they would also have In-Reply-To: and References:,
>> but there is no way for them to reference 0000-cover-letter.patch
>> (because format-patch did not get a chance to generate Message-ID to
>> it), is there?
>
> The patches were generated with git-format-patch but the Message-ID
> was added by patman [1]. The Message-ID encodes the local Change-Id
> which can make it easier to associate one version of the same patch
> with another (same reason gerrit uses Change-Id) [2]. There is no
> Change-Id associated with the cover letter so patman doesn't bother
> adding one there and has always just let it be auto-generated.
> We
> could certainly change patman to make up a Message-Id for the cover
> letter, but there is no real need.
This is a tangent, as I think the earlier patch should fix the
regression, but wouldn't a recipient of such a series have a hard
time to locate and group the patches in the same series with the
cover letter, without having In-Reply-To: or References: that links
the later message back to the initial message (i.e. cover letter)?
Assigning a Message-ID to the cover, and referencing it from the
patches via In-Reply-To:, is what is commonly done, I think, for
that kind of threading.
Thanks.
next prev parent reply other threads:[~2023-05-17 20:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 18:38 bug report: cover letter is inheriting last patch's message ID with send-email Emily Shaffer
2023-05-17 19:01 ` Junio C Hamano
2023-05-17 19:22 ` Junio C Hamano
2023-05-17 20:14 ` Doug Anderson
2023-05-17 20:21 ` Junio C Hamano
2023-05-18 0:51 ` Michael Strawbridge
2023-05-18 1:06 ` Junio C Hamano
2023-05-17 19:24 ` Doug Anderson
2023-05-17 20:04 ` Junio C Hamano [this message]
2023-05-17 20:20 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfs7upvvw.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=dianders@chromium.org \
--cc=git@vger.kernel.org \
--cc=michael.strawbridge@amd.com \
--cc=nasamuffin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).