From: Junio C Hamano <gitster@pobox.com>
To: "Fahad Alrashed via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Karthik Nayak <karthik.188@gmail.com>,
Fahad Alrashed <fahad@keylock.net>
Subject: Re: [PATCH v3] git-p4: show Perforce error to the user
Date: Thu, 09 May 2024 08:30:39 -0700 [thread overview]
Message-ID: <xmqqcypvvw80.fsf@gitster.g> (raw)
In-Reply-To: <pull.1668.v3.git.git.1715206266214.gitgitgadget@gmail.com> (Fahad Alrashed via GitGitGadget's message of "Wed, 08 May 2024 22:11:05 +0000")
"Fahad Alrashed via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Fahad Alrashed <fahad@keylock.net>
>
> During "git p4 clone" if p4 process returns an error from the server,
> it will store the message in the 'err' variable. Then it will send a
> text command "die-now" to git-fast-import. However, git-fast-import
> raises an exception: "fatal: Unsupported command: die-now" and err is
> never displayed. This patch ensures that err is shown to the end user.
>
> Signed-off-by: Fahad Alrashed <fahad@keylock.net>
> ---
Looking good. Queued. Thanks.
prev parent reply other threads:[~2024-05-09 15:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-04 5:57 [PATCH] Bug fix: ensure P4 "err" is displayed when exception is raised Fahad Alrashed via GitGitGadget
2024-05-06 12:01 ` Karthik Nayak
2024-05-08 11:46 ` [PATCH v2] " Fahad Alrashed via GitGitGadget
2024-05-08 16:53 ` Junio C Hamano
2024-05-08 22:11 ` [PATCH v3] git-p4: show Perforce error to the user Fahad Alrashed via GitGitGadget
2024-05-09 15:30 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqcypvvw80.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=fahad@keylock.net \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=karthik.188@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).