Git Mailing List Archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Nathan Faulkner <natedogith1@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] diff: document what --name-only shows
Date: Tue, 21 May 2024 18:35:38 -0700	[thread overview]
Message-ID: <xmqq7cfmiq6t.fsf@gitster.g> (raw)
In-Reply-To: <4c4049e9-f5fa-41c3-8a6a-df4fca2f07f1@gmail.com> (Nathan Faulkner's message of "Sat, 18 May 2024 15:10:01 -0400")

Nathan Faulkner <natedogith1@gmail.com> writes:

> This new description sounds to me like it only shows files that exist
> in the to-commit, not any files that were deleted.

True.  

The thing is "diff" works on pair of files from old side and new
side, so a removed path still conceptually exists on both sides as a
change from

    <old path name, old state (has certain contents)>

to

    <new path name, new state (no longer exists)>

It is the same story for a created path.

Having learned that, a proposal to rephrase the updated
documentation is very much welcomed.

Thanks.


      reply	other threads:[~2024-05-22  1:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-17 17:14 [PATCH] diff: document what --name-only shows Junio C Hamano
2024-05-18 19:10 ` Nathan Faulkner
2024-05-22  1:35   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7cfmiq6t.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=natedogith1@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).