From: Junio C Hamano <gitster@pobox.com>
To: "Rubén Justo" <rjusto@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH v2 0/4] mark t3701-add-interactive.sh as leak-free
Date: Mon, 22 Apr 2024 16:26:58 -0700 [thread overview]
Message-ID: <xmqq4jbtt1vh.fsf@gitster.g> (raw)
In-Reply-To: <69f86760-96ff-4c62-9649-4627652b7c19@gmail.com> ("Rubén Justo"'s message of "Tue, 23 Apr 2024 00:51:04 +0200")
Rubén Justo <rjusto@gmail.com> writes:
> Range-diff against v1:
> 1: 18e4c7f653 ! 1: 75cb700eab apply: plug a leak in apply_data
> @@ Metadata
> ## Commit message ##
> apply: plug a leak in apply_data
>
> - Plug a leak we have since cfb6f9acc3 (apply: accept -3/--3way command
> - line option, 2012-05-08).
> + We have an execution path in apply_data that leaks the local struct
> + image. Plug it.
This is a nice improvement.
If a bug existed in an ancient version and survived across evolution
of the code for a long time, naming a random old version that
happened to already have it does not help very much.
Saying something like
This is an ancient bug whose moral equivalent existed even
before the data & code structure became the current shape in
commit X
would give a bit more information, in that X gives a rough estimate
how far back in the codebase the fix in the patch can be applied
more or less cleanly. In this case, X would be where the struct
image was introduced, I guess?
But the updated text is good enough and I do not see a need for
reroll. Will queue. Thanks.
prev parent reply other threads:[~2024-04-22 23:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-21 10:22 [PATCH 0/4] mark t3701-add-interactive.sh as leak-free Rubén Justo
2024-04-21 10:27 ` [PATCH 2/4] add-interactive: plug a leak in get_untracked_files Rubén Justo
2024-04-22 15:50 ` Junio C Hamano
2024-04-21 10:28 ` [PATCH 1/4] apply: plug a leak in apply_data Rubén Justo
2024-04-22 15:41 ` Phillip Wood
2024-04-22 22:04 ` Rubén Justo
2024-04-22 22:27 ` Junio C Hamano
2024-04-21 10:28 ` [PATCH 3/4] add-patch: plug a leak handling the '/' command Rubén Justo
2024-04-21 10:29 ` [PATCH 4/4] add: plug a leak on interactive_add Rubén Justo
2024-04-22 15:43 ` Phillip Wood
2024-04-22 23:04 ` Rubén Justo
2024-04-22 6:06 ` [PATCH 0/4] mark t3701-add-interactive.sh as leak-free Patrick Steinhardt
2024-04-22 15:30 ` Junio C Hamano
2024-04-22 22:51 ` [PATCH v2 " Rubén Justo
2024-04-22 22:54 ` [PATCH v2 1/4] apply: plug a leak in apply_data Rubén Justo
2024-04-22 22:54 ` [PATCH v2 2/4] add-interactive: plug a leak in get_untracked_files Rubén Justo
2024-04-22 22:54 ` [PATCH v2 3/4] add-patch: plug a leak handling the '/' command Rubén Justo
2024-04-22 22:54 ` [PATCH v2 4/4] add: plug a leak on interactive_add Rubén Justo
2024-04-22 23:26 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4jbtt1vh.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=rjusto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).