From: Junio C Hamano <gitster@pobox.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: git@vger.kernel.org, "brian m. carlson" <sandals@crustytoothpaste.net>
Subject: Re: [PATCH] tests: make 'test_oid' print trailing newline
Date: Fri, 23 Dec 2022 09:56:39 +0900 [thread overview]
Message-ID: <xmqq3597rl88.fsf@gitster.g> (raw)
In-Reply-To: <20221222185804.GE3411@szeder.dev> ("SZEDER Gábor"'s message of "Thu, 22 Dec 2022 19:58:04 +0100")
SZEDER Gábor <szeder.dev@gmail.com> writes:
> On Mon, Dec 19, 2022 at 09:48:49AM +0900, Junio C Hamano wrote:
>> SZEDER Gábor <szeder.dev@gmail.com> writes:
>> > $ git grep '\stest_oid ' -- ':/t/*.sh'
>> > $ git grep 'echo "\?$(test_oid ' -- ':/t/*.sh'
>> ...
>> I found these examples in the log message a bit annoying to see, as
>> experiments are not affected by any grep.patterntype), but they may
>> fail for folks on stricter platforms.
>
> Please feel free to amend the commit message as you see fit. Usually
> I would do that myself as I'm rather picky of my commit messages, but,
> alas, I'm not versed in portability issues of regexes, so I'm not sure
> what the right regexes would be.
I guess ERE would give us enough expressiveness to say "zero or one"
without relying on GNU extension. Saying "Any whitespace" concisely
as "\s" would require PCRE (i.e. "grep -P") but because use of it is
optional, the best we could do is "[ ]" (in the [bracket]), one is
TAB and the other is SPACE).
But reading the message again, they are what the author of the patch
did to observe the current codebase, so I think being faithful to
what you did would be fine ;-)
In any case, thanks for cleaning it up.
next prev parent reply other threads:[~2022-12-23 0:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-18 16:29 [PATCH] tests: make 'test_oid' print trailing newline SZEDER Gábor
2022-12-19 0:48 ` Junio C Hamano
2022-12-22 18:58 ` SZEDER Gábor
2022-12-23 0:56 ` Junio C Hamano [this message]
2022-12-19 14:03 ` brian m. carlson
2022-12-19 15:27 ` Ævar Arnfjörð Bjarmason
2022-12-19 23:58 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq3597rl88.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=sandals@crustytoothpaste.net \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).