From: Junio C Hamano <gitster@pobox.com>
To: Jakub Wilk <jwilk@jwilk.net>
Cc: <git@vger.kernel.org>, Eric Wong <normalperson@yhbt.net>
Subject: Re: [PATCH] git-clone.txt: document -4 and -6
Date: Thu, 01 Jun 2023 15:06:35 +0900 [thread overview]
Message-ID: <xmqq1qivd8d0.fsf@gitster.g> (raw)
In-Reply-To: <20230527123849.5990-1-jwilk@jwilk.net> (Jakub Wilk's message of "Sat, 27 May 2023 14:38:49 +0200")
Jakub Wilk <jwilk@jwilk.net> writes:
> These options were added in c915f11eb4 ("connect & http: support -4 and
> -6 switches for remote operations").
>
> Signed-off-by: Jakub Wilk <jwilk@jwilk.net>
> ---
> Documentation/git-clone.txt | 8 ++++++++
> 1 file changed, 8 insertions(+)
The patch is not _wrong_ per-se, but there are other options that
are common among the "fetch" family of commands. I counted at least
these should be shared between "fetch" and "clone", by splitting
them out of "fetch-options.txt" into a new file, and including that
new file from "fetch-options.txt" and "git-clone.txt". Those marked
with (?) are described in different phrasing between "clone" and
"fetch", and may fall into the "let's keep them separate, because
they mean different things" category (later):
* --jobs
* --upload-pack
* --quiet (?)
* --verbose (?)
* --progress
* --server-option
* --ipv[46]
Note that these happen to share the same name, but to "clone" and
"fetch" they different things, so leaving them separate is the right
thing to do.
* --no-tags
* --recurse-submodules
Thanks.
next prev parent reply other threads:[~2023-06-01 6:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-27 12:38 [PATCH] git-clone.txt: document -4 and -6 Jakub Wilk
2023-06-01 6:06 ` Junio C Hamano [this message]
2024-01-02 18:58 ` Jakub Wilk
2024-01-02 19:56 ` Taylor Blau
2024-01-02 20:36 ` Taylor Blau
2024-01-02 22:15 ` Junio C Hamano
2024-01-02 22:25 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1qivd8d0.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jwilk@jwilk.net \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).