From: "Linus Arver via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Jonathan Tan <jonathantanmy@google.com>,
Emily Shaffer <nasamuffin@google.com>,
Patrick Steinhardt <ps@pks.im>,
Matthieu Moy <git@matthieu-moy.fr>,
Linus Arver <linusa@google.com>
Subject: [PATCH v2 0/8] docs: recommend using contrib/contacts/git-contacts
Date: Sat, 06 Apr 2024 01:22:08 +0000 [thread overview]
Message-ID: <pull.1704.v2.git.1712366536.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.1704.git.1712017205754.gitgitgadget@gmail.com>
Make git-contacts more prominent in our docs.
Notable changes in v2
=====================
* Improve existing mention of git-contacts in SubmittingPatches (instead of
adding a separate, entirely new paragraph)
* Add example usage of integrating git-contacts with git-send-email with
the latter's --cc-cmd flag.
* Various smaller fixes to SubmittingPatches
Linus Arver (8):
MyFirstContribution: mention contrib/contacts/git-contacts
SubmittingPatches: make 'git contacts' grep-friendly
SubmittingPatches: mention GitGitGadget
SubmittingPatches: quote commands
SubmittingPatches: discuss reviewers first
SubmittingPatches: dedupe discussion of security patches
SubmittingPatches: add heading for format-patch and send-email
SubmittingPatches: demonstrate using git-contacts with git-send-email
Documentation/MyFirstContribution.txt | 5 ++
Documentation/SubmittingPatches | 68 +++++++++++++++------------
2 files changed, 43 insertions(+), 30 deletions(-)
base-commit: c2cbfbd2e28cbe27c194d62183b42f27a6a5bb87
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1704%2Flistx%2Freviewers-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1704/listx/reviewers-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/1704
Range-diff vs v1:
1: 7f1ac742008 ! 1: 3817e7f3cd0 docs: recommend using contrib/contacts/git-contacts
@@ Metadata
Author: Linus Arver <linusa@google.com>
## Commit message ##
- docs: recommend using contrib/contacts/git-contacts
+ MyFirstContribution: mention contrib/contacts/git-contacts
Although we've had this script since 4d06402b1b (contrib: add
git-contacts helper, 2013-07-21), we don't mention it in our
@@ Documentation/MyFirstContribution.txt: $ git send-email --to=target@example.com
valuable, such as changing the Reply-to address or adding more CC and BCC lines.
+NOTE: Use `contrib/contacts/git-contacts` to get a list of reviewers you should
-+include in the CC list.
++include in the CC list. In addition, you can do `git send-email --cc-cmd='git
++contacts' feature/*.patch` to automatically pass this list of emails to
++`send-email`.
+
NOTE: When you are sending a real patch, it will go to git@vger.kernel.org - but
please don't send your patchset from the tutorial to the real mailing list! For
now, you can send it to yourself, to make sure you understand how it will look.
-
- ## Documentation/SubmittingPatches ##
-@@ Documentation/SubmittingPatches: an explanation of changes between each iteration can be kept in
- Git-notes and inserted automatically following the three-dash
- line via `git format-patch --notes`.
-
-+[[suggested-reviewers]]
-+Use `contrib/contacts/git-contacts` to get a list of reviewers you should
-+include in the CC list.
-+
- [[attachment]]
- Do not attach the patch as a MIME attachment, compressed or not.
- Do not let your e-mail client send quoted-printable. Do not let
-: ----------- > 2: 82e5e05288d SubmittingPatches: make 'git contacts' grep-friendly
-: ----------- > 3: 6e6950afa6e SubmittingPatches: mention GitGitGadget
-: ----------- > 4: fb06d5ce247 SubmittingPatches: quote commands
-: ----------- > 5: a8abcf45881 SubmittingPatches: discuss reviewers first
-: ----------- > 6: 326afe13315 SubmittingPatches: dedupe discussion of security patches
-: ----------- > 7: 09f4e7ad123 SubmittingPatches: add heading for format-patch and send-email
-: ----------- > 8: b35748f0cf8 SubmittingPatches: demonstrate using git-contacts with git-send-email
--
gitgitgadget
next prev parent reply other threads:[~2024-04-06 1:22 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 0:20 [PATCH] docs: recommend using contrib/contacts/git-contacts Linus Arver via GitGitGadget
2024-04-02 6:28 ` Patrick Steinhardt
2024-04-04 20:00 ` Linus Arver
2024-04-03 8:42 ` Matthias Aßhauer
2024-04-03 16:13 ` Junio C Hamano
2024-04-04 20:01 ` Linus Arver
[not found] ` <35192e61-c442-6719-caf0-1019bf3e44c9@live.de>
2024-04-03 10:11 ` [RFC] git-contacts: exclude list (was: Re: [PATCH] docs: recommend using contrib/contacts/git-contacts) Matthias Aßhauer
2024-04-03 16:39 ` [RFC] git-contacts: exclude list Junio C Hamano
[not found] ` <ac044ecd116d4491b5f6cdddc0266486@SAMBXP02.univ-lyon1.fr>
2024-04-03 12:13 ` Matthieu Moy
2024-04-06 1:22 ` Linus Arver via GitGitGadget [this message]
2024-04-06 1:22 ` [PATCH v2 1/8] MyFirstContribution: mention contrib/contacts/git-contacts Linus Arver via GitGitGadget
2024-04-06 2:22 ` Junio C Hamano
2024-04-09 1:08 ` Linus Arver
2024-04-09 1:49 ` Junio C Hamano
2024-04-06 1:22 ` [PATCH v2 2/8] SubmittingPatches: make 'git contacts' grep-friendly Linus Arver via GitGitGadget
2024-04-06 2:23 ` Junio C Hamano
2024-04-06 1:22 ` [PATCH v2 3/8] SubmittingPatches: mention GitGitGadget Linus Arver via GitGitGadget
2024-04-06 2:26 ` Junio C Hamano
2024-04-09 1:10 ` Linus Arver
2024-04-09 1:49 ` Junio C Hamano
2024-04-06 1:22 ` [PATCH v2 4/8] SubmittingPatches: quote commands Linus Arver via GitGitGadget
2024-04-06 1:22 ` [PATCH v2 5/8] SubmittingPatches: discuss reviewers first Linus Arver via GitGitGadget
2024-04-06 1:22 ` [PATCH v2 6/8] SubmittingPatches: dedupe discussion of security patches Linus Arver via GitGitGadget
2024-04-06 1:22 ` [PATCH v2 7/8] SubmittingPatches: add heading for format-patch and send-email Linus Arver via GitGitGadget
2024-04-06 1:22 ` [PATCH v2 8/8] SubmittingPatches: demonstrate using git-contacts with git-send-email Linus Arver via GitGitGadget
2024-04-06 2:28 ` [PATCH v2 0/8] docs: recommend using contrib/contacts/git-contacts Junio C Hamano
2024-04-09 21:56 ` [PATCH v3 " Linus Arver via GitGitGadget
2024-04-09 21:56 ` [PATCH v3 1/8] MyFirstContribution: mention contrib/contacts/git-contacts Linus Arver via GitGitGadget
2024-04-09 22:20 ` Linus Arver
2024-04-09 23:02 ` Junio C Hamano
2024-04-09 23:42 ` Linus Arver
2024-04-11 22:53 ` Linus Arver
2024-04-09 21:56 ` [PATCH v3 2/8] SubmittingPatches: make 'git contacts' grep-friendly Linus Arver via GitGitGadget
2024-04-09 21:56 ` [PATCH v3 3/8] SubmittingPatches: mention GitGitGadget Linus Arver via GitGitGadget
2024-04-09 21:56 ` [PATCH v3 4/8] SubmittingPatches: quote commands Linus Arver via GitGitGadget
2024-04-09 21:56 ` [PATCH v3 5/8] SubmittingPatches: discuss reviewers first Linus Arver via GitGitGadget
2024-04-10 0:27 ` Eric Sunshine
2024-04-10 0:36 ` Junio C Hamano
2024-04-10 1:13 ` Linus Arver
2024-04-09 21:56 ` [PATCH v3 6/8] SubmittingPatches: dedupe discussion of security patches Linus Arver via GitGitGadget
2024-04-09 21:56 ` [PATCH v3 7/8] SubmittingPatches: add heading for format-patch and send-email Linus Arver via GitGitGadget
2024-04-09 21:56 ` [PATCH v3 8/8] SubmittingPatches: demonstrate using git-contacts with git-send-email Linus Arver via GitGitGadget
2024-04-11 0:19 ` Kipras Melnikovas
2024-04-11 21:03 ` Linus Arver
2024-04-12 8:48 ` Kipras Melnikovas
2024-04-11 23:32 ` [PATCH v4 0/8] docs: recommend using contrib/contacts/git-contacts Linus Arver via GitGitGadget
2024-04-11 23:32 ` [PATCH v4 1/8] MyFirstContribution: mention contrib/contacts/git-contacts Linus Arver via GitGitGadget
2024-04-11 23:32 ` [PATCH v4 2/8] SubmittingPatches: clarify 'git-contacts' location Linus Arver via GitGitGadget
2024-04-12 17:09 ` Junio C Hamano
2024-04-12 18:45 ` Eric Sunshine
2024-04-13 1:26 ` Junio C Hamano
2024-04-16 22:44 ` Linus Arver
2024-04-16 22:57 ` Junio C Hamano
2024-04-16 23:07 ` Linus Arver
2024-04-17 2:40 ` Junio C Hamano
2024-04-17 5:38 ` Junio C Hamano
2024-04-17 5:48 ` Eric Sunshine
2024-04-17 14:47 ` Junio C Hamano
2024-04-17 23:13 ` Linus Arver
2024-04-17 23:08 ` Linus Arver
2024-04-18 18:13 ` Linus Arver
2024-04-11 23:32 ` [PATCH v4 3/8] SubmittingPatches: mention GitGitGadget Linus Arver via GitGitGadget
2024-04-11 23:32 ` [PATCH v4 4/8] SubmittingPatches: quote commands Linus Arver via GitGitGadget
2024-04-11 23:32 ` [PATCH v4 5/8] SubmittingPatches: discuss reviewers first Linus Arver via GitGitGadget
2024-04-11 23:32 ` [PATCH v4 6/8] SubmittingPatches: dedupe discussion of security patches Linus Arver via GitGitGadget
2024-04-11 23:32 ` [PATCH v4 7/8] SubmittingPatches: add heading for format-patch and send-email Linus Arver via GitGitGadget
2024-04-11 23:32 ` [PATCH v4 8/8] SubmittingPatches: demonstrate using git-contacts with git-send-email Linus Arver via GitGitGadget
2024-04-12 17:19 ` Junio C Hamano
2024-04-16 0:21 ` Linus Arver
2024-04-16 23:01 ` [PATCH v5 0/8] docs: recommend using contrib/contacts/git-contacts Linus Arver via GitGitGadget
2024-04-16 23:01 ` [PATCH v5 1/8] MyFirstContribution: mention contrib/contacts/git-contacts Linus Arver via GitGitGadget
2024-04-16 23:01 ` [PATCH v5 2/8] SubmittingPatches: clarify 'git-contacts' location Linus Arver via GitGitGadget
2024-04-16 23:01 ` [PATCH v5 3/8] SubmittingPatches: mention GitGitGadget Linus Arver via GitGitGadget
2024-04-16 23:01 ` [PATCH v5 4/8] SubmittingPatches: quote commands Linus Arver via GitGitGadget
2024-04-16 23:01 ` [PATCH v5 5/8] SubmittingPatches: discuss reviewers first Linus Arver via GitGitGadget
2024-04-16 23:01 ` [PATCH v5 6/8] SubmittingPatches: dedupe discussion of security patches Linus Arver via GitGitGadget
2024-04-16 23:01 ` [PATCH v5 7/8] SubmittingPatches: add heading for format-patch and send-email Linus Arver via GitGitGadget
2024-04-16 23:01 ` [PATCH v5 8/8] SubmittingPatches: demonstrate using git-contacts with git-send-email Linus Arver via GitGitGadget
2024-04-18 21:51 ` [PATCH v6 0/8] docs: recommend using contrib/contacts/git-contacts Linus Arver via GitGitGadget
2024-04-18 21:51 ` [PATCH v6 1/8] MyFirstContribution: mention contrib/contacts/git-contacts Linus Arver via GitGitGadget
2024-04-18 21:51 ` [PATCH v6 2/8] SubmittingPatches: clarify 'git-contacts' location Linus Arver via GitGitGadget
2024-04-18 21:52 ` [PATCH v6 3/8] SubmittingPatches: mention GitGitGadget Linus Arver via GitGitGadget
2024-04-18 21:52 ` [PATCH v6 4/8] SubmittingPatches: quote commands Linus Arver via GitGitGadget
2024-04-18 21:52 ` [PATCH v6 5/8] SubmittingPatches: discuss reviewers first Linus Arver via GitGitGadget
2024-04-18 21:52 ` [PATCH v6 6/8] SubmittingPatches: dedupe discussion of security patches Linus Arver via GitGitGadget
2024-04-18 21:52 ` [PATCH v6 7/8] SubmittingPatches: add heading for format-patch and send-email Linus Arver via GitGitGadget
2024-04-18 21:52 ` [PATCH v6 8/8] SubmittingPatches: demonstrate using git-contacts with git-send-email Linus Arver via GitGitGadget
2024-04-18 21:56 ` [PATCH v6 0/8] docs: recommend using contrib/contacts/git-contacts Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.1704.v2.git.1712366536.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@matthieu-moy.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
--cc=linusa@google.com \
--cc=nasamuffin@google.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).