Git Mailing List Archive mirror
 help / color / mirror / Atom feed
From: "Mohit Marathe via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Mohit Marathe <mohitmarathe@proton.me>
Subject: [PATCH 0/2] git-compat-util: move convert_slashes from compat/mingw.h and rename it
Date: Mon, 18 Mar 2024 12:47:40 +0000	[thread overview]
Message-ID: <pull.1699.git.1710766062.gitgitgadget@gmail.com> (raw)

Hi all,

This series aims to complete a #leftoverbits: https://lore.kernel.org/
git/xmqqzfw43xad.fsf@gitster.g/ by moving convert_slashes() to
git-compat-util.h and renaming it to change_path_separators().

I appreciate your review and feedback on this patch series.

Best regards, Mohit Marathe

Mohit Marathe (2):
  git-compat-util: migrate `convert_slashes()` from compat/mingw.h
  test-lib: replace repeated code logic with an existing helper

 abspath.c               | 4 ++--
 compat/mingw.c          | 4 ++--
 compat/mingw.h          | 6 ------
 git-compat-util.h       | 7 +++++++
 path.c                  | 2 +-
 t/unit-tests/test-lib.c | 9 +++------
 6 files changed, 15 insertions(+), 17 deletions(-)


base-commit: 2953d95d402b6bff1a59c4712f4d46f1b9ea137f
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1699%2Fmohit-marathe%2Fconvert-slashes-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1699/mohit-marathe/convert-slashes-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1699
-- 
gitgitgadget

             reply	other threads:[~2024-03-18 12:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-18 12:47 Mohit Marathe via GitGitGadget [this message]
2024-03-18 12:47 ` [PATCH 1/2] git-compat-util: migrate `convert_slashes()` from compat/mingw.h Mohit Marathe via GitGitGadget
2024-03-18 21:57   ` Junio C Hamano
2024-03-18 12:47 ` [PATCH 2/2] test-lib: replace repeated code logic with an existing helper Mohit Marathe via GitGitGadget
2024-03-18 21:58   ` Junio C Hamano
2024-04-11 21:42   ` Josh Steadmon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pull.1699.git.1710766062.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=mohitmarathe@proton.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).