From: "Linus Arver via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: "Christian Couder [ ]" <chriscool@tuxfamily.org>,
"Junio C Hamano [ ]" <gitster@pobox.com>,
"Emily Shaffer [ ]" <nasamuffin@google.com>,
"Josh Steadmon [ ]" <steadmon@google.com>,
"Randall S. Becker [ ]" <rsbecker@nexbridge.com>,
"Christian Couder [ ]" <christian.couder@gmail.com>,
Kristoffer Haugsbakk <[code@khaugsbakk.name]>,
Linus Arver <linusa@google.com>
Subject: [PATCH 0/5] Unify trailer formatting functions
Date: Fri, 15 Mar 2024 06:55:00 +0000 [thread overview]
Message-ID: <pull.1694.git.1710485706.gitgitgadget@gmail.com> (raw)
This series is based on the initial series [1], notably the v4 version of
patches 10-16 as suggested by Christian [2]. This version addresses the
review comments for those patches, namely the avoidance of (temporary) test
breakages.
The central idea is to unify the functions format_trailer_info() and
format_trailers() together (preferring the name of the latter), so that both
the interpret-trailers built-in and format_trailers_from_commit() can call
the same format_trailers() function, while maintaining feature parity.
[1]
https://lore.kernel.org/git/pull.1632.v4.git.1707196348.gitgitgadget@gmail.com/
[2]
https://lore.kernel.org/git/CAP8UFD08F0V13X0+CJ1uhMPzPWVMs2okGVMJch0DkQg5M3BWLA@mail.gmail.com/
Linus Arver (5):
format_trailer_info(): use trailer_item objects
format_trailer_info(): drop redundant unfold_value()
format_trailer_info(): append newline for non-trailer lines
trailer: begin formatting unification
trailer: finish formatting unification
trailer.c | 81 ++++++++++++++++++++-----------------------------------
trailer.h | 13 +++------
2 files changed, 32 insertions(+), 62 deletions(-)
base-commit: 4f9b731bdeccffa1b13e5edf4bc0428b8d49704e
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1694%2Flistx%2Ftrailer-api-part-2-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1694/listx/trailer-api-part-2-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1694
--
gitgitgadget
next reply other threads:[~2024-03-15 6:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 6:55 Linus Arver via GitGitGadget [this message]
2024-03-15 6:55 ` [PATCH 1/5] format_trailer_info(): use trailer_item objects Linus Arver via GitGitGadget
2024-03-15 6:55 ` [PATCH 2/5] format_trailer_info(): drop redundant unfold_value() Linus Arver via GitGitGadget
2024-03-15 6:55 ` [PATCH 3/5] format_trailer_info(): append newline for non-trailer lines Linus Arver via GitGitGadget
2024-03-15 17:22 ` Junio C Hamano
2024-03-15 6:55 ` [PATCH 4/5] trailer: begin formatting unification Linus Arver via GitGitGadget
2024-03-15 6:55 ` [PATCH 5/5] trailer: finish " Linus Arver via GitGitGadget
2024-03-15 17:20 ` [PATCH 0/5] Unify trailer formatting functions Junio C Hamano
2024-03-15 18:26 ` Kristoffer Haugsbakk
2024-03-15 19:10 ` Junio C Hamano
2024-03-15 21:36 ` Linus Arver
2024-03-15 21:43 ` Junio C Hamano
2024-03-26 21:57 ` Junio C Hamano
2024-04-02 0:27 ` Linus Arver
2024-04-15 21:02 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.1694.git.1710485706.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nasamuffin@google.com \
--cc=rsbecker@nexbridge.com \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).