From: "Chris. Webster via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: "Chris. Webster" <chris@webstech.net>
Subject: [PATCH v2 0/3] Make check-whitespace failures more helpful
Date: Tue, 20 Dec 2022 00:35:44 +0000 [thread overview]
Message-ID: <pull.1444.v2.git.1671496548.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.1444.git.1671179520.gitgitgadget@gmail.com>
Add the errors to the job summary along with suggested commands to fix the
problem. The commits and filenames are links.
This is for issue #1395. Sample job output
[https://github.com/webstech/check-whitespace/actions/runs/3707382446]:
❌ A whitespace issue was found in one or more of the commits.
Run these commands to correct the problem:
1. git rebase --whitespace=fix aaa04a9
2. git push --force
Errors:
1. --- 5cd37f6 Remove annotations
trailing.txt:4: trailing whitespace.
+
trailing.txt:2: new blank line at EOF.
Chris. Webster (3):
ci (check-whitespace): suggest fixes for errors
ci (check-whitespace): add links to job output
ci (check-whitespace): move to actions/checkout@v3
.github/workflows/check-whitespace.yml | 57 +++++++++++++++++++++-----
1 file changed, 46 insertions(+), 11 deletions(-)
base-commit: 57e2c6ebbe7108b35ba30184dcbcb6c34c929ad8
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1444%2Fwebstech%2Fwhitespace-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1444/webstech/whitespace-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/1444
Range-diff vs v1:
1: 67f60e4e5cb ! 1: a2b5f3e87d6 Make `check-whitespace` failures more helpful
@@ Metadata
Author: Chris. Webster <chris@webstech.net>
## Commit message ##
- Make `check-whitespace` failures more helpful
+ ci (check-whitespace): suggest fixes for errors
- Add the errors to the job summary along with suggested
- commands to fix the problem.
+ Make the errors more visible by adding them to the job summary and
+ display the git commands that will usually fix the problem.
Signed-off-by: Chris. Webster <chris@webstech.net>
## .github/workflows/check-whitespace.yml ##
@@ .github/workflows/check-whitespace.yml: jobs:
- check-whitespace:
- runs-on: ubuntu-latest
- steps:
-- - uses: actions/checkout@v2
-+ - uses: actions/checkout@v3
- with:
- fetch-depth: 0
-
- name: git log --check
id: check_out
run: |
2: cdc2b1aae81 ! 2: 342167ef5bd Improve check-whitespace output
@@ Metadata
Author: Chris. Webster <chris@webstech.net>
## Commit message ##
- Improve check-whitespace output
+ ci (check-whitespace): add links to job output
A message in the step log will refer to the Summary output.
- The job summary output now has links to the commits and files.
+ The job summary output is using markdown to improve readability. The
+ git commands and commits with errors are now in ordered lists.
+ Commits and files in error are links to the user's repository.
Signed-off-by: Chris. Webster <chris@webstech.net>
-: ----------- > 3: aa8cd940940 ci (check-whitespace): move to actions/checkout@v3
--
gitgitgadget
next prev parent reply other threads:[~2022-12-20 0:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 8:31 [PATCH 0/2] Make check-whitespace failures more helpful Chris. Webster via GitGitGadget
2022-12-16 8:31 ` [PATCH 1/2] Make `check-whitespace` " Chris. Webster via GitGitGadget
2022-12-16 10:06 ` Junio C Hamano
2022-12-20 0:30 ` Chris Webster
2022-12-20 1:36 ` Junio C Hamano
2022-12-20 5:50 ` Chris Webster
2022-12-16 8:32 ` [PATCH 2/2] Improve check-whitespace output Chris. Webster via GitGitGadget
2022-12-16 10:13 ` Junio C Hamano
2022-12-20 0:33 ` Chris Webster
2022-12-20 0:35 ` Chris. Webster via GitGitGadget [this message]
2022-12-20 0:35 ` [PATCH v2 1/3] ci (check-whitespace): suggest fixes for errors Chris. Webster via GitGitGadget
2022-12-20 7:34 ` Đoàn Trần Công Danh
2022-12-20 19:55 ` Chris Webster
2022-12-21 1:53 ` Đoàn Trần Công Danh
2022-12-21 6:08 ` Chris Webster
2022-12-21 13:46 ` Đoàn Trần Công Danh
2022-12-20 0:35 ` [PATCH v2 2/3] ci (check-whitespace): add links to job output Chris. Webster via GitGitGadget
2022-12-20 0:35 ` [PATCH v2 3/3] ci (check-whitespace): move to actions/checkout@v3 Chris. Webster via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.1444.v2.git.1671496548.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=chris@webstech.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).