From: "Rose via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Rose <83477269+AtariDreams@users.noreply.github.com>,
Seija Kijin <doremylover123@gmail.com>
Subject: [PATCH] Remove redundant double exclamation points
Date: Mon, 19 Dec 2022 14:12:43 +0000 [thread overview]
Message-ID: <pull.1401.git.git.1671459163559.gitgitgadget@gmail.com> (raw)
From: Seija Kijin <doremylover123@gmail.com>
S_ISDIR is a macro that involves a "==" comparison.
This means the !! is redundant and not needed.
Signed-off-by: Seija Kijin <doremylover123@gmail.com>
---
Remove redundant double exclamation points
S_ISDIR is a macro that involves a "==" comparison.
This means the !! is redundant and not needed.
Signed-off-by: Seija Kijin doremylover123@gmail.com
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1401%2FAtariDreams%2FIS_DIR-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1401/AtariDreams/IS_DIR-v1
Pull-Request: https://github.com/git/git/pull/1401
tree-walk.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/tree-walk.c b/tree-walk.c
index 74f4d710e8f..6b51d27ccb2 100644
--- a/tree-walk.c
+++ b/tree-walk.c
@@ -1040,9 +1040,9 @@ static enum interesting do_match(struct index_state *istate,
ps->max_depth == -1)
return all_entries_interesting;
return within_depth(base->buf + base_offset, baselen,
- !!S_ISDIR(entry->mode),
- ps->max_depth) ?
- entry_interesting : entry_not_interesting;
+ S_ISDIR(entry->mode), ps->max_depth) ?
+ entry_interesting :
+ entry_not_interesting;
}
pathlen = tree_entry_len(entry);
@@ -1073,8 +1073,7 @@ static enum interesting do_match(struct index_state *istate,
if (within_depth(base_str + matchlen + 1,
baselen - matchlen - 1,
- !!S_ISDIR(entry->mode),
- ps->max_depth))
+ S_ISDIR(entry->mode), ps->max_depth))
goto interesting;
else
return entry_not_interesting;
base-commit: 7c2ef319c52c4997256f5807564523dfd4acdfc7
--
gitgitgadget
next reply other threads:[~2022-12-19 14:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 14:12 Rose via GitGitGadget [this message]
2022-12-19 15:19 ` [PATCH] Remove redundant double exclamation points Ævar Arnfjörð Bjarmason
2022-12-20 0:50 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.1401.git.git.1671459163559.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=83477269+AtariDreams@users.noreply.github.com \
--cc=doremylover123@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).