From: Justin Tobler <jltobler@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Kristoffer Haugsbakk <code@khaugsbakk.name>,
Roland Hieber <rhi@pengutronix.de>,
Denton Liu <liu.denton@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH v3 1/3] completion: add 'symbolic-ref'
Date: Thu, 25 Apr 2024 16:40:15 -0500 [thread overview]
Message-ID: <prwckjhoktcmdgl7637jekssonghcjcbsyuivwzq6w6eqvl7g5@nfumrglobhyl> (raw)
In-Reply-To: <xmqqh6fpgzs6.fsf@gitster.g>
On 24/04/25 09:42AM, Junio C Hamano wrote:
> Justin Tobler <jltobler@gmail.com> writes:
>
> >> (I was going to link to SubmittingPatches here but I didn’t find a
> >> mention of it there. Apparently I misremembered.)
> >
> > There is a section in the MyFirstContribution docs that mentions it
> > briefly:
> >
> > https://git-scm.com/docs/MyFirstContribution#v2-git-send-email
>
> Thanks for noticing.
>
> We should improve the situation by probably moving[*] more from the
> latter to SubmittingPatches so that people do not need to refer to
> both just to find out the essentials.
>
>
> [*] If it is small, just copy; if it is large, move and then replace
> the original with a reference into SubmittingPatches.
>
I think this is a good idea. Submitted a patch that attempts to improve
this.
https://lore.kernel.org/git/20240425213404.133660-1-jltobler@gmail.com/
-Justin
next prev parent reply other threads:[~2024-04-25 21:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 10:18 [PATCH v3 1/3] completion: add 'symbolic-ref' Roland Hieber
2024-04-25 10:18 ` [PATCH v3 2/3] completion: improve docs for using __git_complete Roland Hieber
2024-04-25 10:18 ` [PATCH v3 3/3] completion: add docs on how to add subcommand completions Roland Hieber
2024-04-25 10:45 ` [PATCH v3 1/3] completion: add 'symbolic-ref' Kristoffer Haugsbakk
2024-04-25 14:36 ` Justin Tobler
2024-04-25 16:42 ` Junio C Hamano
2024-04-25 21:40 ` Justin Tobler [this message]
2024-04-25 21:48 ` Junio C Hamano
2024-04-25 16:50 ` Junio C Hamano
2024-04-26 11:43 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=prwckjhoktcmdgl7637jekssonghcjcbsyuivwzq6w6eqvl7g5@nfumrglobhyl \
--to=jltobler@gmail.com \
--cc=code@khaugsbakk.name \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=liu.denton@gmail.com \
--cc=rhi@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).