From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 303F3EC875B for ; Thu, 7 Sep 2023 21:02:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240869AbjIGVCQ (ORCPT ); Thu, 7 Sep 2023 17:02:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240015AbjIGVCP (ORCPT ); Thu, 7 Sep 2023 17:02:15 -0400 Received: from mail.manjaro.org (mail.manjaro.org [IPv6:2a01:4f8:c0c:51f3::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91B5092 for ; Thu, 7 Sep 2023 14:02:11 -0700 (PDT) MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1694120528; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kky672JZRNVnMXacoIx8kskUp+ba6+14zPT2f2/7x6E=; b=BqY3Qxp7gZNPJ8WoWPYarHsXzfUzry0NKIzD5dbIOzjFAdtk6/XAagLOV4ShYP+p0Chkjp wUWWIMhxGQQPNOVdNWguPSXHZ0rI5jHIcdZGpVQK9JmkOY/fCG94fidXiaLQXIwHUfyq+E WWjQgcu4zN2TzTHKq2fje/5TOw2dgW3tXco4ouRu3JWqLDPJhLvAQLYCt/jymUiFtH/aGK bxmdtWhZLHs725pBChqXrMvrrENxqSoby4oHG+Uvp1iDIAtJNhugmP8X7W8p1sCJYOwOvs aZ7d45zDB6F3z5uDV3n70iSOscD/ucNsCxgVNdBuSGOQkXRIFKmjfolcsGR0tw== Date: Thu, 07 Sep 2023 23:02:07 +0200 From: Dragan Simic To: Christian Couder Cc: Toon Claes , git@vger.kernel.org, Junio C Hamano , Patrick Steinhardt , Johannes Schindelin , Elijah Newren , John Cai , Derrick Stolee , Phillip Wood , Felipe Contreras , Calvin Wan , Christian Couder Subject: Re: [PATCH v3 11/15] replay: use standard revision ranges In-Reply-To: References: <20230509175347.1714141-1-christian.couder@gmail.com> <20230602102533.876905-1-christian.couder@gmail.com> <20230602102533.876905-12-christian.couder@gmail.com> <87legbsths.fsf@iotcl.com> Message-ID: X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 2023-09-07 10:32, Christian Couder wrote: > On Thu, Jun 22, 2023 at 12:03 PM Toon Claes wrote: >> >> Christian Couder writes: >> >> > +DESCRIPTION >> > +----------- >> > + >> > +Takes a range of commits, and replays them onto a new location. Does >> > +not touch the working tree or index, and does not update any >> > +references. However, the output of this command is meant to be used >> >> Small suggestion here: >> >> Takes a range of commits, and replays them onto a new location. Does >> neither touch the working tree nor index, and does not update any >> references. > > I am not a native speaker, so I am not sure what's best here. I find > your suggestion a bit less clear though, so until a native speaker > agrees with it or maybe finds something even better, I prefer to leave > it as-is. I'm also not a native English speaker, but I spent about 2.5 years contributing a whole lot to English Wikipedia, so I'd dare to say I've honed my English skills rather well. Thus, here's my take on this: Takes a range of commits and replays them onto a new location. Leaves the working tree and the index untouched, and updates no references. The output of this command is to be used... This is written in a concise yet slightly imperative way, which should be suitable for the purpose. I hope you agree.