From: Brian Inglis <Brian.Inglis@Shaw.ca>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: Re: manual option --inline --no-attach override required for format.attach
Date: Fri, 17 Feb 2023 15:12:10 -0700 [thread overview]
Message-ID: <e6696187-6fda-5b24-e2ba-91d323ffbfc3@Shaw.ca> (raw)
In-Reply-To: <xmqqr0uqwovt.fsf@gitster.g>
On 2023-02-15 15:21, Junio C Hamano wrote:
> Brian Inglis <Brian.Inglis@Shaw.ca> writes:
>
>> What did you do before the bug happened? (Steps to reproduce your issue)
>> git format-patch --inline ... --to=linux-man@vger.kernel.org
>
> This is documented to use multipart/mixed attachement with
> "Content-Disposition: inline".
>
>> git format-patch --no-attach ... --to=linux-man@vger.kernel.org
>
> This should be the default, text/plain patch contained inline in the
> message.
>
>> git send-email ... --to=linux-man@vger.kernel.org
>
> It is unclera what ... hides on this command line, but if you sent
> output from both of the above two format-patch invocations, then the
> output from the first invocation of format-patch with --inline would
> be MIME multipart messages, so it is understandable if the recipient
> sees such messages.
Thanks Junio,
I think I was being confused by a project maintainer insisting on --inline when
what he really wanted was --no-attach to get inline patches for his process, no
other project previously caring that /etc/gitconfig had format.attach, and my
not even being aware that was set until I checked!
I also found my ISP had added outgoing milter rate limiting, rejecting
everything after the 5th patch email in a series, adding to our situation!
But the point stands that there is no way to switch attach off in local or repo
config if it is on in a more global config, other than remembering to manually
specify --no-attach on every git format-patch. Suggest allowing attach=no|off|0.
This would benefit those contributing from orgs tightly controlled environments
where they may be unable to change global configs.
There should also be a config item if project maintainers want to see --inline
attachments, working in the same manner as attach, or as an argument of attach?
--
Take care. Thanks, Brian Inglis Calgary, Alberta, Canada
La perfection est atteinte Perfection is achieved
non pas lorsqu'il n'y a plus rien à ajouter not when there is no more to add
mais lorsqu'il n'y a plus rien à retirer but when there is no more to cut
-- Antoine de Saint-Exupéry
next prev parent reply other threads:[~2023-02-17 22:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 21:51 manual option --inline --no-attach override required for format.attach Brian Inglis
2023-02-15 22:21 ` Junio C Hamano
2023-02-17 22:12 ` Brian Inglis [this message]
2023-02-16 1:29 ` manual option --inline --no-attach override required for format.attachg brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6696187-6fda-5b24-e2ba-91d323ffbfc3@Shaw.ca \
--to=brian.inglis@shaw.ca \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).