From: Rafael Dulfer <rafael@dulfer.be>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "Jeff King" <peff@peff.net>,
"Andrei Rybak" <rybak.a.v@gmail.com>,
"Rafael Dulfer" <rafael.dulfer@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH] rev-list: clarify git-log default date format
Date: Thu, 2 Feb 2023 12:37:37 +0100 [thread overview]
Message-ID: <d9fc8688-bbf1-96c2-07bf-a12fe38625a9@dulfer.be> (raw)
In-Reply-To: <xmqqy1phxabi.fsf@gitster.g>
> Add "on day X at time Y" here, and I'd buy that 😉
Feels to me that adding "on day X at time Y" is a bit superfluous, since
it's quite obvious from the examples, but I guess it can't hurt to be exact.
I think it would be a good idea to still have _some_ text for
`--date=default`, just so the structure of the sections stays the same
over all the date options. Maybe just something simple like.
"`--date=default` is the default format. It is a custom format based on
rfc2822". And then below that we have the table (which is more a
conclusion to the section, as it provides examples for a few, more
unclear, formats)
On 01/02/2023 23:58, Junio C Hamano wrote:
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>>> That is
>>>
>>> The default format `--date=default` shows a single line with
>>> three-letter day of the week, three-letter month, day-of-month,
>>> hour-minute-second in the "HH:MM:SS" format, followed by 4-digit
>>> year, plus timezone information unless the local time zone is
>>> used (e.g. "Thu Jan 1 00:00:00 1970 +0000").
>>>
>>> or something like that.
>> I think that following such a description in prose is still more
>> confusing than just showing an example. E.g. we could say:
>>
>> Assuming a user in timezone +0200 (Central Europe) values of
> Add "on day X at time Y" here, and I'd buy that ;-)
>
>> these `--date` argument would produce:
>>
>> |---------------+--------------------------------|
>> | rfc2822 | Thu, 7 Apr 2005 15:13:13 -0700 |
>> | rfc2822-local | Fri, 8 Apr 2005 00:13:13 +0200 |
>> | default | Thu Apr 7 15:13:13 2005 -0700 |
>> | default-local | Fri Apr 8 00:13:13 2005 |
>> |---------------+--------------------------------|
next prev parent reply other threads:[~2023-02-02 11:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 15:57 [PATCH] rev-list: clarify git-log default date format Rafael Dulfer
2023-02-01 18:19 ` Junio C Hamano
2023-02-01 22:28 ` Ævar Arnfjörð Bjarmason
2023-02-01 22:58 ` Junio C Hamano
2023-02-02 11:37 ` Rafael Dulfer [this message]
2023-02-02 16:17 ` Junio C Hamano
2023-02-02 16:53 ` Junio C Hamano
2023-02-16 0:42 ` [PATCH v2] " Junio C Hamano
2023-02-16 2:15 ` Jeff King
2023-02-16 2:58 ` Junio C Hamano
2023-02-16 16:29 ` [PATCH v3] " Junio C Hamano
2023-02-16 17:24 ` Jeff King
2023-02-01 22:47 ` [PATCH] " Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9fc8688-bbf1-96c2-07bf-a12fe38625a9@dulfer.be \
--to=rafael@dulfer.be \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=rafael.dulfer@gmail.com \
--cc=rybak.a.v@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).