From: Patrick Steinhardt <ps@pks.im>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/8] tightening ref handling outside of refs/
Date: Mon, 29 Apr 2024 11:28:38 +0200 [thread overview]
Message-ID: <Zi9oRuknlhfG1-WX@tanuki> (raw)
In-Reply-To: <20240429084238.GA242085@coredump.intra.peff.net>
[-- Attachment #1: Type: text/plain, Size: 1625 bytes --]
On Mon, Apr 29, 2024 at 04:42:38AM -0400, Jeff King wrote:
> On Mon, Apr 29, 2024 at 04:15:13AM -0400, Jeff King wrote:
>
> > [1/8]: t0600: don't create ref outside of refs/
> > [2/8]: t5619: use fully qualified refname for branch
>
> You can probably guess that I found these test cleanups only after
> writing the rest of the series and seeing them fail. :)
>
> It turns out there is one more spot that is run only with reftables (so
> CI caught it, but my local testing did not):
Yeah, that's an issue by itself in my opinion. It's ultimately the
reason why I change this to always run the backend-specific tests in
[1].
> diff --git a/t/t0610-reftable-basics.sh b/t/t0610-reftable-basics.sh
> index 178791e086..c6dbd2b5c4 100755
> --- a/t/t0610-reftable-basics.sh
> +++ b/t/t0610-reftable-basics.sh
> @@ -343,11 +343,11 @@ test_expect_success 'ref transaction: env var disables compaction' '
> for i in $(test_seq $iterations)
> do
> GIT_TEST_REFTABLE_AUTOCOMPACTION=false \
> - git -C repo update-ref branch-$i HEAD || return 1
> + git -C repo update-ref refs/heads/branch-$i HEAD || return 1
> done &&
> test_line_count = $expected repo/.git/reftable/tables.list &&
>
> - git -C repo update-ref foo HEAD &&
> + git -C repo update-ref refs/heads/foo HEAD &&
> test_line_count -lt $expected repo/.git/reftable/tables.list
> '
>
> I'll wait for comments before re-rolling, but I'll make sure that gets
> added in.
The fix looks reasonable.
Patrick
[1]: https://lore.kernel.org/git/acf0c285506fe7ba275b08cdaf6b2245ec66b565.1712896869.git.ps@pks.im/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-04-29 9:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 8:15 [PATCH 0/8] tightening ref handling outside of refs/ Jeff King
2024-04-29 8:16 ` [PATCH 1/8] t0600: don't create ref " Jeff King
2024-04-29 8:36 ` [PATCH 0/8] tightening ref handling " Jeff King
2024-04-29 8:42 ` Jeff King
2024-04-29 9:28 ` Patrick Steinhardt [this message]
2024-04-30 10:45 ` Jeff King
2024-04-29 15:01 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zi9oRuknlhfG1-WX@tanuki \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).