From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Christian Couder <christian.couder@gmail.com>, git <git@vger.kernel.org>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Jakub Narebski" <jnareb@gmail.com>,
"Markus Jansen" <mja@jansen-preisler.de>,
"Kaartic Sivaraam" <kaartic.sivaraam@gmail.com>,
"Taylor Blau" <me@ttaylorr.com>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Bruno Brito" <bruno@git-tower.com>,
"Thomas Bock" <bockthom@cs.uni-saarland.de>,
"Kristoffer Haugsbakk" <code@khaugsbakk.name>,
"Derrick Stolee" <derrickstolee@github.com>,
"Phillip Wood" <phillip.wood@dunelm.org.uk>
Subject: Re: Draft of Git Rev News edition 99
Date: Tue, 30 May 2023 08:10:01 +0700 [thread overview]
Message-ID: <ZHVM6dw4lIHjdLGw@debian.me> (raw)
In-Reply-To: <CAP8UFD2zaEPKNj2SpgGQUyFRmNp24E-8n1O9K5Se9=OhXckxGQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1170 bytes --]
On Tue, May 30, 2023 at 12:34:17AM +0200, Christian Couder wrote:
> Everyone is welcome to contribute in any section either by editing the
> above page on GitHub and sending a pull request, or by commenting on
> this GitHub issue:
>
> https://github.com/git/git.github.io/issues/643
>
> You can also reply to this email.
From the draft:
> After some discussions between Peff, Phillip and Junio, Peff sent a version 3
> of his patch series with small changes. Especially the new version makes sure
> we reject timestamps that start with a character that we don't consider a
> whitespace or a digit or the - character before using strtoumax(3) as this was
> considered enough to avoid issues related to this function.
I think it's odd to have second person (we) when the text is written in
third-person perspective. Thus, abouve should have been:
> ... Especially in the new version, it made sure that timestamps that were
> started with a character that wasn't considered as either a whitespace, a
> digit, or - character, were rejected before using strtoumax(3) ...
Thanks.
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-05-30 1:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-29 22:34 Draft of Git Rev News edition 99 Christian Couder
2023-05-30 1:10 ` Bagas Sanjaya [this message]
2023-06-02 10:19 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHVM6dw4lIHjdLGw@debian.me \
--to=bagasdotme@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=bockthom@cs.uni-saarland.de \
--cc=bruno@git-tower.com \
--cc=christian.couder@gmail.com \
--cc=code@khaugsbakk.name \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=kaartic.sivaraam@gmail.com \
--cc=me@ttaylorr.com \
--cc=mja@jansen-preisler.de \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).