Git Mailing List Archive mirror
 help / color / mirror / Atom feed
From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: M Hickford via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, peff@peff.net, msuchanek@suse.de,
	lessleydennington@gmail.com, me@ttaylorr.com,
	mjcheetham@github.com, M Hickford <mirth.hickford@gmail.com>
Subject: Re: [PATCH] doc: gitcredentials: introduce OAuth helpers
Date: Sun, 28 May 2023 22:51:07 +0000	[thread overview]
Message-ID: <ZHPa27fbAoKL0uGj@tapette.crustytoothpaste.net> (raw)
In-Reply-To: <pull.1538.git.1685303127237.gitgitgadget@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1143 bytes --]

On 2023-05-28 at 19:45:27, M Hickford via GitGitGadget wrote:
> From: M Hickford <mirth.hickford@gmail.com>
> 
> OAuth credential helpers are widely useful but work differently to other
> credential helpers, so worth introducing in the docs.
> 
> Link to relevant projects.

There are many possible implementations of credential helpers, and I'd
prefer we didn't specifically propose any of them here.  We ship with
some in contrib, and I think it would be better to fix them to be
functional for this use case rather than link to external projects.

I expect, however, that functionally, that will be difficult to do,
given the fact that OAuth typically requires registration with the
remote system, and thus we'd intrinsically be prioritizing some
well-known forges over less-known or personally-hosted forges, which
we've traditionally tried not to do.  For example, your
git-credential-oauth contains a hard-coded list of 11 forges (and also
proposes adding credentials for new ones into the config, which isn't
really a secure way to store secrets).
-- 
brian m. carlson (he/him or they/them)
Toronto, Ontario, CA

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

  reply	other threads:[~2023-05-28 22:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-28 19:45 [PATCH] doc: gitcredentials: introduce OAuth helpers M Hickford via GitGitGadget
2023-05-28 22:51 ` brian m. carlson [this message]
2023-05-29  9:50   ` M Hickford
2023-06-21  6:28   ` M Hickford
2023-06-21  7:30 ` [PATCH v2] doc: gitcredentials: link to helper list M Hickford via GitGitGadget
2023-06-27  8:21   ` Jeff King
2023-07-08 20:36   ` [PATCH v3] " M Hickford via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZHPa27fbAoKL0uGj@tapette.crustytoothpaste.net \
    --to=sandals@crustytoothpaste.net \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=lessleydennington@gmail.com \
    --cc=me@ttaylorr.com \
    --cc=mirth.hickford@gmail.com \
    --cc=mjcheetham@github.com \
    --cc=msuchanek@suse.de \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).