From: Todd Zullinger <tmz@pobox.com>
To: git@vger.kernel.org
Cc: Matthew John Cheetham <mjcheetham@outlook.com>,
Jeff King <peff@peff.net>
Subject: [BUG 2.41.0] t/lib-httpd/apache.conf incompatible with RHEL/CentOS 7
Date: Wed, 17 May 2023 15:06:18 -0400 [thread overview]
Message-ID: <ZGUlqu7sP7yxbaTI@pobox.com> (raw)
After applying the imap-send.c patch¹ on RHEL/CentOS 7, I
noticed the http tests fail because the Apache httpd config
is not valid with httpd-2.4.6² on CentOS 7.
The tests fail with:
Parse errors: No plan found in TAP output
The problem is that CGIPassAuth, added in 988aad99b4 (t5563:
add tests for basic and anoymous HTTP access, 2023-02-27) is
not supported by httpd < 2.4.13:
Starting httpd on port 10410
[Wed May 17 17:06:52.184409 2023] [core:warn] [pid 477886] AH00111: Config variable ${LIB_HTTPD_SVN} is not defined
[Wed May 17 17:06:52.184495 2023] [core:warn] [pid 477886] AH00111: Config variable ${LIB_HTTPD_SVNPATH} is not defined
AH00526: Syntax error on line 149 of /builddir/build/BUILD/git-2.41.0.rc0/t/lib-httpd/apache.conf:
Invalid command 'CGIPassAuth', perhaps misspelled or defined by a module not included in the server configuration
error: web server setup failed
Since edd060dc84 (t/lib-httpd: bump required apache version
to 2.4, 2023-02-01), we require httpd-2.4 and no longer have
any <IfVersion> conditions. I'm not sure if this a reason
to add some again (nor am I certain if httpd's IfVersion
supports minor versions).
Perhaps there's a more elegant way to fix this? (I haven't
thought of anything in patch form yet, apologies.)
I'd like to still build git for CentOS 7 and not skip all
the http tests, but if it's time to say it is not worth
supporting, I can understand. RHEL/CentOS 7 has a little
over a year left before it is EOL³.
¹ <20230517070632.71884-1-list@eworm.de>
² https://httpd.apache.org/docs/2.4/mod/core.html#cgipassauth
³ https://blog.centos.org/2023/04/end-dates-are-coming-for-centos-stream-8-and-centos-linux-7/#centos-linux-7-end-of-life-june-30-2024
Thanks,
--
Todd
next reply other threads:[~2023-05-17 19:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 19:06 Todd Zullinger [this message]
2023-05-18 18:45 ` [BUG 2.41.0] t/lib-httpd/apache.conf incompatible with RHEL/CentOS 7 Jeff King
2023-05-18 19:14 ` Todd Zullinger
2023-05-18 19:22 ` Jeff King
2023-05-18 19:21 ` Jeff King
2023-05-18 19:50 ` Todd Zullinger
2023-05-18 20:11 ` Todd Zullinger
2023-05-18 21:31 ` Junio C Hamano
2023-05-18 21:28 ` Junio C Hamano
2023-05-18 23:10 ` Jeff King
2023-05-18 23:23 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGUlqu7sP7yxbaTI@pobox.com \
--to=tmz@pobox.com \
--cc=git@vger.kernel.org \
--cc=mjcheetham@outlook.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).