On Tue, May 09, 2023 at 10:58:33AM -0700, Junio C Hamano wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> 
> > Add a testcase that exercises the logic when an invalid output format is
> > passed via the `fetch.output` configuration.
> >
> > Signed-off-by: Patrick Steinhardt <ps@pks.im>
> > ---
> >  t/t5574-fetch-output.sh | 19 +++++++++++++++++++
> >  1 file changed, 19 insertions(+)
> 
> It makes perfect sense to make sure that invalid input gets rejected
> and the command exits with non-zero status, and it is probably a
> good thing that the end-user sees a message that explains why the
> particular input is rejected (even though it adds one more thing
> that needs to be updated when the message gets reworded).
> 
> But do we need to insist on no output to the standard output stream
> when the command errors out?
> 
> Other than that, looking good.

Not really, no. Will change.

Patrick