From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Rafael Dulfer <rafael@dulfer.be>,
git@vger.kernel.org, Andrei Rybak <rybak.a.v@gmail.com>,
Rafael Dulfer <rafael.dulfer@gmail.com>
Subject: Re: [PATCH] rev-list: clarify git-log default date format
Date: Wed, 1 Feb 2023 17:47:26 -0500 [thread overview]
Message-ID: <Y9rr/hfnrV2zmyWf@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqq5ycl1c6h.fsf@gitster.g>
On Wed, Feb 01, 2023 at 10:19:02AM -0800, Junio C Hamano wrote:
> > - - there is no comma after the day-of-week
> > + - There is no comma after the day-of-week
> >
> > - - the time zone is omitted when the local time zone is used
> > + - The time zone is omitted when the local time zone is used
> > +
> > + - Day-of-month and month are switched around
> > +
> > + - Time-of-day and the year are switched around
> > +
> > +As a result, the format looks as follows: `Thu Jan 1 00:00:00 1970 +0000` with `+0000` being omitted when the local time zone is used.
>
> All of the above may technically be correct, but I wonder if it
> makes it easier to follow to simply stop saying "is similar to".
> That is
>
> The default format `--date=default` shows a single line with
> three-letter day of the week, three-letter month, day-of-month,
> hour-minute-second in the "HH:MM:SS" format, followed by 4-digit
> year, plus timezone information unless the local time zone is
> used (e.g. "Thu Jan 1 00:00:00 1970 +0000").
>
> or something like that.
Yes, I agree with your suggestion. When you can explain something as
"like X, but Y" it is helpful when Y is short. When it becomes much
longer, than simply spelling out what X is becomes more helpful.
-Peff
prev parent reply other threads:[~2023-02-01 22:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 15:57 [PATCH] rev-list: clarify git-log default date format Rafael Dulfer
2023-02-01 18:19 ` Junio C Hamano
2023-02-01 22:28 ` Ævar Arnfjörð Bjarmason
2023-02-01 22:58 ` Junio C Hamano
2023-02-02 11:37 ` Rafael Dulfer
2023-02-02 16:17 ` Junio C Hamano
2023-02-02 16:53 ` Junio C Hamano
2023-02-16 0:42 ` [PATCH v2] " Junio C Hamano
2023-02-16 2:15 ` Jeff King
2023-02-16 2:58 ` Junio C Hamano
2023-02-16 16:29 ` [PATCH v3] " Junio C Hamano
2023-02-16 17:24 ` Jeff King
2023-02-01 22:47 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9rr/hfnrV2zmyWf@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rafael.dulfer@gmail.com \
--cc=rafael@dulfer.be \
--cc=rybak.a.v@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).