From: Taylor Blau <me@ttaylorr.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Taylor Blau <me@ttaylorr.com>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] t7610: fix flaky timeout issue, don't clone from example.com
Date: Wed, 9 Nov 2022 21:17:25 -0500 [thread overview]
Message-ID: <Y2xfNcCfkij6k4Uk@nand.local> (raw)
In-Reply-To: <221110.864jv7ptbq.gmgdl@evledraar.gmail.com>
On Thu, Nov 10, 2022 at 12:55:30AM +0100, Ævar Arnfjörð Bjarmason wrote:
> But we generally just fail some or all of 3..9 pretty fast, and don't
> start taking 20 minutes to run the test, when it took 10s before (or
> whatever).
OK. I still think that in principle this is indistinguishable from not
running a setup test to completion.
*But*: I'm willing to treat them differently since instead of
manifesting in an immediate failure later on in the suite, we hang for a
substantial period of time.
So I'm content to merge this down, but I don't think it's worth
searching out for more of these in the future.
Thanks,
Taylor
next prev parent reply other threads:[~2022-11-10 2:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-05 11:54 [PATCH] t7610: fix flaky timeout issue, don't clone from example.com Ævar Arnfjörð Bjarmason
2022-11-09 22:47 ` Taylor Blau
2022-11-09 23:55 ` Ævar Arnfjörð Bjarmason
2022-11-10 2:17 ` Taylor Blau [this message]
2022-11-15 19:42 ` Taylor Blau
2022-11-15 23:40 ` [PATCH] t7610: use "file:///dev/null", not "/dev/null", fixes MinGW Ævar Arnfjörð Bjarmason
2022-11-16 1:07 ` Taylor Blau
2022-11-17 10:08 ` Ævar Arnfjörð Bjarmason
2022-11-17 21:50 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2xfNcCfkij6k4Uk@nand.local \
--to=me@ttaylorr.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).