From: "J. Paul Reed" <preed@sigkill.com>
To: Thomas Guyot <tguyot@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Odd git-config behavior
Date: Tue, 8 Nov 2022 15:08:45 -0800 [thread overview]
Message-ID: <Y2rhfTYDEGQ7EhaS@sigkill.com> (raw)
In-Reply-To: <bc3aa4b1-4716-cf9c-5dff-22b25793f66c@gmail.com>
On 04 Nov 2022 at 07:47:46, Thomas Guyot arranged the bits on my disk to say:
> What prevents you from getting the owned uid or the repos and forking a
> process as that user to run the check?
Laziness?
I should note: these aren't really "untrusted" user repositories, so I'm
not very concerned about it (though I understand your point).
This does beg the question: does running "git fsck" on an untrusted
repository as another user present a [security] problem?
If so, should it?
> > 2. I think it might be useful to warn the user that the behavior they're
> > expecting isn't happening due to this security check, instead of just
> > outputting objectively wrong information (i.e. that no config options
> > exist when they actually do exist); I'd be curious what others think.
>
> What was the return code for the git config command? If it was zero when
> it didn't parse/output the config option you asked for that is
> definitively a bug. If you failed to check the return code of git-config
> then you should fix your script/tool instead.
underworld # ~preed/src/git/git --version
git version 2.30.2.4.g8959555cee
underworld # GIT_PAGER=cat ~preed/src/git/git-config -l
underworld # echo $?
0
best,
preed
--
J. Paul Reed
https://jpaulreed.com
PGP: 0x41AA0EF1
next prev parent reply other threads:[~2022-11-08 23:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 20:51 Odd git-config behavior J. Paul Reed
2022-11-04 11:47 ` Thomas Guyot
2022-11-08 23:08 ` J. Paul Reed [this message]
2022-11-09 7:02 ` Thomas Guyot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2rhfTYDEGQ7EhaS@sigkill.com \
--to=preed@sigkill.com \
--cc=git@vger.kernel.org \
--cc=tguyot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).