From: Taylor Blau <me@ttaylorr.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "Derrick Stolee" <derrickstolee@github.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] ci: avoid unnecessary builds
Date: Tue, 8 Nov 2022 13:30:20 -0500 [thread overview]
Message-ID: <Y2qgPKRW1+9BNkIp@nand.local> (raw)
In-Reply-To: <75ono097-16nr-nno4-rqoq-rrn79spps249@tzk.qr>
On Tue, Nov 08, 2022 at 09:18:21AM +0100, Johannes Schindelin wrote:
> > I played around with the following, but I can't quite get Actions to
> > like it. The error message I get (ref[1]) is something like:
> >
> > The workflow is not valid. .github/workflows/main.yml (Line: 96, Col:
> > 27): Unexpected value 'needs.ci-config.outputs.skip_concurrent == 'yes''
> > .github/workflows/main.yml (Line: 123, Col: 27): Unexpected value
> > 'needs.ci-config.outputs.skip_concurrent == 'yes''
>
> The reason is that what you are trying to do simply cannot work.
I was surprised that I couldn't get this to work, because to me it
seemed like the sort of thing that *should* be possible to do.
Indeed, it is, and I made a couple of mistakes in writing the workflow
file:
- The expression for 'skip-in-progress' needed to be enclosed in
'${{}}' markers.
- It also needed to take into account the job name (and matrix
information!) where relevant. And here we can't just use
${{github.job}}, since that is only available inside of the job
steps.
To the last bullet point there, we unfortunately have to copy and paste
the job name, which seems like a limitation of the Actions workflow
parser to me.
I posted an alternative approach to this patch in [1], and I would be
very curious to hear your thoughts, if you have time!
Thanks,
Taylor
[1]: https://lore.kernel.org/git/cover.1667931937.git.me@ttaylorr.com/T/#t
next prev parent reply other threads:[~2022-11-08 18:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 13:34 [PATCH] ci: avoid unnecessary builds Johannes Schindelin via GitGitGadget
2022-11-04 1:46 ` Ævar Arnfjörð Bjarmason
2022-11-04 2:23 ` Taylor Blau
2022-11-04 3:20 ` Jeff King
2022-11-08 9:16 ` Johannes Schindelin
2022-11-09 14:00 ` Jeff King
2022-11-10 2:40 ` Taylor Blau
2022-11-04 2:09 ` Taylor Blau
2022-11-07 19:45 ` Derrick Stolee
2022-11-07 19:53 ` Taylor Blau
2022-11-07 20:08 ` Derrick Stolee
2022-11-07 21:03 ` Ævar Arnfjörð Bjarmason
2022-11-07 21:59 ` Derrick Stolee
2022-11-07 22:44 ` Taylor Blau
2022-11-08 8:18 ` Johannes Schindelin
2022-11-08 18:30 ` Taylor Blau [this message]
2022-11-07 22:56 ` Ævar Arnfjörð Bjarmason
2022-11-08 0:02 ` Derrick Stolee
2022-11-08 0:31 ` Junio C Hamano
2022-11-08 9:51 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2qgPKRW1+9BNkIp@nand.local \
--to=me@ttaylorr.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).