From: Jeff King <peff@peff.net>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Taylor Blau <me@ttaylorr.com>, git@vger.kernel.org
Subject: Re: ab/make-bin-wrappers (was: What's cooking in git.git (Nov 2022, #01; Thu, 3))
Date: Tue, 8 Nov 2022 09:27:50 -0500 [thread overview]
Message-ID: <Y2pnZic1mi205/MQ@coredump.intra.peff.net> (raw)
In-Reply-To: <221107.86h6zax26k.gmgdl@evledraar.gmail.com>
On Mon, Nov 07, 2022 at 03:33:40PM +0100, Ævar Arnfjörð Bjarmason wrote:
>
> On Thu, Nov 03 2022, Taylor Blau wrote:
>
> > * ab/make-bin-wrappers (2022-10-31) 4 commits
> > - Makefile: simplify $(test_bindir_programs) rule by splitting it up
> > - Makefile: rename "test_bindir_programs" variable, pre-declare
> > - Makefile: define "TEST_{PROGRAM,OBJS}" variables earlier
> > - Makefile: factor sed-powered '#!/bin/sh' munging into a variable
> >
> > Resolve issues with the bin-wrappers/% rules where "make
> > bin-wrappers/git" would generate the script but not "git" itself.
> >
> > Waiting for review.
> > source: <cover-v3-0.4-00000000000-20221031T222249Z-avarab@gmail.com>
>
> On my end I'm waiting to see what you and/or Jeff think about:
> https://lore.kernel.org/git/221101.86edun5tgn.gmgdl@evledraar.gmail.com/
I don't have any strong opinion on that. I read the v2 cover letter, was
skeptical/confused of the motivation, and didn't go much further.
Your explanation in the linked email is that there are _other_ reasons
to do this refactoring, but I don't have any knowledge there that would
add to the review. My gut is still that building bin-wrappers/foo
doesn't need to depend on foo, but if it's one line, I don't care that
much either way. If it was 50 lines of complicated Makefile refactoring,
then would probably not be worth it.
-Peff
next prev parent reply other threads:[~2022-11-08 14:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 1:05 What's cooking in git.git (Nov 2022, #01; Thu, 3) Taylor Blau
2022-11-05 0:21 ` Philip Oakley
2022-11-05 0:26 ` Taylor Blau
2022-11-07 12:19 ` Philip Oakley
2022-11-08 21:49 ` Taylor Blau
2022-11-07 14:28 ` ab/config-multi-and-nonbool (was: What's cooking in git.git (Nov 2022, #01; Thu, 3)) Ævar Arnfjörð Bjarmason
2022-11-07 14:33 ` ab/make-bin-wrappers " Ævar Arnfjörð Bjarmason
2022-11-08 14:27 ` Jeff King [this message]
2022-11-08 21:52 ` Taylor Blau
2022-11-09 14:04 ` Jeff King
2022-11-07 21:14 ` ab/coccicheck-incremental " Ævar Arnfjörð Bjarmason
2022-11-08 21:53 ` Taylor Blau
2022-11-07 21:24 ` ab/sha-makefile-doc " Ævar Arnfjörð Bjarmason
2022-11-08 14:13 ` ab/submodule-helper-prep-only " Ævar Arnfjörð Bjarmason
2022-11-08 22:04 ` Taylor Blau
2022-11-08 14:14 ` ab/cmake-nix-and-ci " Ævar Arnfjörð Bjarmason
2022-11-08 14:49 ` Phillip Wood
2022-11-08 14:22 ` ab/misc-hook-submodule-run-command " Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2pnZic1mi205/MQ@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).