From: Taylor Blau <me@ttaylorr.com>
To: Alison Winters via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, "Alison Winters" <alisonatwork@outlook.com>,
"Jacob Keller" <jacob.keller@gmail.com>,
"SZEDER Gábor" <szeder.dev@gmail.com>,
"Lessley Dennington" <lessleydennington@gmail.com>
Subject: Re: [PATCH 0/2] add case insensitivity option to bash completion
Date: Mon, 7 Nov 2022 22:00:02 -0500 [thread overview]
Message-ID: <Y2nGMquKVz4vDNDS@nand.local> (raw)
In-Reply-To: <pull.1374.git.git.1667669315.gitgitgadget@gmail.com>
Hi Alison,
On Sat, Nov 05, 2022 at 05:28:33PM +0000, Alison Winters via GitGitGadget wrote:
> Alison Winters (2):
> completion: add optional ignore-case when matching refs
> completion: add case-insensitive match of pseudorefs
>
> contrib/completion/git-completion.bash | 51 ++++++++++++++++++++++++--
> t/t9902-completion.sh | 32 ++++++++++++++++
> 2 files changed, 80 insertions(+), 3 deletions(-)
It looks reasonable to me, but I'm far from an expert on the completion
code ;-).
CC'ing some folks who are going to be more familiar with it than me.
Thanks,
Taylor
next prev parent reply other threads:[~2022-11-08 3:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-05 17:28 [PATCH 0/2] add case insensitivity option to bash completion Alison Winters via GitGitGadget
2022-11-05 17:28 ` [PATCH 1/2] completion: add optional ignore-case when matching refs Alison Winters via GitGitGadget
2022-11-20 20:24 ` SZEDER Gábor
2022-11-05 17:28 ` [PATCH 2/2] completion: add case-insensitive match of pseudorefs Alison Winters via GitGitGadget
2022-11-20 20:42 ` SZEDER Gábor
2022-11-20 20:46 ` SZEDER Gábor
2022-11-08 3:00 ` Taylor Blau [this message]
2022-11-21 0:26 ` [PATCH v2 0/2] add case insensitivity option to bash completion Alison Winters via GitGitGadget
2022-11-21 0:26 ` [PATCH v2 1/2] completion: add optional ignore-case when matching refs Alison Winters via GitGitGadget
2022-11-21 0:26 ` [PATCH v2 2/2] completion: add case-insensitive match of pseudorefs Alison Winters via GitGitGadget
2022-11-29 2:38 ` [PATCH 0/2] add case insensitivity option to bash completion Junio C Hamano
2022-11-29 15:56 ` Alison Winters
2022-11-29 17:40 ` Ævar Arnfjörð Bjarmason
2022-11-30 0:37 ` Alison Winters
2022-11-30 3:08 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2nGMquKVz4vDNDS@nand.local \
--to=me@ttaylorr.com \
--cc=alisonatwork@outlook.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=jacob.keller@gmail.com \
--cc=lessleydennington@gmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).