From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09527C433FE for ; Sun, 16 Oct 2022 13:14:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229597AbiJPNOI (ORCPT ); Sun, 16 Oct 2022 09:14:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229607AbiJPNNv (ORCPT ); Sun, 16 Oct 2022 09:13:51 -0400 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB1EA3C8CE for ; Sun, 16 Oct 2022 06:13:49 -0700 (PDT) Received: by mail-pg1-x531.google.com with SMTP id s196so7000747pgs.3 for ; Sun, 16 Oct 2022 06:13:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=c9P6GLV6upD5Wlen41KwbyKwZU+0Gtet4W4jpUOgU+k=; b=pTDn+v3TrEd847+FnQiQeJDO8OZRIesTFR1xdI72rVjZfBGUdOaSdA+OTlsAtwAP9l VZ4sb8z26Pt7zoLFhlba0nizSinsg4kj2i91/G4l+lnm38R7wYW57stOimMicpqyRkVB dYxvNuMF6ypMNJ+DTiwkD3ixROWyTKT7i/YJwPqRFBDf5N+r0hOgLOIGlj3TFvdXMzbq uDA1SF41zn2yepQJf9raYiBY93GOyOdS1duw47WMYK7+g4ssPD48/X5U8L5MGpGAadcI dtRON4lOnatMndRiqMgxlk3BaY4LK2bBJfRlAeE4NcZbHK3V0vgPDCLDtfNUOM/zKJhL N/Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=c9P6GLV6upD5Wlen41KwbyKwZU+0Gtet4W4jpUOgU+k=; b=Yl9wzkds5JXwWOKdYmyG1tCNA8UZzudiiGY8OKkc6XmmgL3RXURFXzi1a/lBrs0F6N DR7mJ1HatCYE1paix0j+yacmzKKPVQisCPpu5XM3bWJvPyijYr4PZji1HZpp2+bVr+v9 5uUjPoC02zmRyhg+K0alDVYN2aX8BBmlR8hjCoi6eKnUMkb8RLhXBvCwOOTuG0ZYxdxm VsNssaguq4nKEpn1AH1iALQ9OVuZFaF+Hcn0UdCiwQxAqeC9PgdFNYHITs3tsFawDDN4 Uvg1uX9hOkn8TiTyVg866dK7v7+/kRIzy3P1oqJJqS5oARW42ZBSO/5YsOmYRNKHlOIW 2BIQ== X-Gm-Message-State: ACrzQf1Wp0FdPbSuaNqOGkJexeaadbXKqCcRwV48VDsTysroFr/RnVh/ xiC/9JKkci7eSjfrYAxpH/8LgPNZHRI= X-Google-Smtp-Source: AMsMyM6RB8Ma0OjCxI9uEQ+hMvuULWeL97LUkjUCuwMn5TBuL5B4xtSgtxi1QCHBKuCa6WFpk0NZ+Q== X-Received: by 2002:a05:6a00:114c:b0:528:2c7a:630e with SMTP id b12-20020a056a00114c00b005282c7a630emr7447468pfm.86.1665926029414; Sun, 16 Oct 2022 06:13:49 -0700 (PDT) Received: from localhost ([2001:ee0:500b:6370:da47:cda5:dbd5:6e77]) by smtp.gmail.com with ESMTPSA id y23-20020a17090264d700b0017a04542a45sm4741751pli.159.2022.10.16.06.13.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Oct 2022 06:13:48 -0700 (PDT) Date: Sun, 16 Oct 2022 20:13:45 +0700 From: =?utf-8?B?xJBvw6BuIFRy4bqnbiBDw7RuZw==?= Danh To: skrab-sah via GitGitGadget Cc: git@vger.kernel.org, =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , skrab-sah Subject: Re: [PATCH v2] abspath.h file is generated by makeheaders tool Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 2022-10-13 16:40:32+0000, skrab-sah via GitGitGadget wrote: > From: skrab-sah > > 1. We don't need to commit the file. > 2. Added routin for abspath.c in Makefile. > 3. Added tool support for makeheaders. > > Signed-off-by: skrab-sah > --- [...] > diff --git a/Makefile b/Makefile > index cac3452edb9..e1136e96283 100644 > --- a/Makefile > +++ b/Makefile > @@ -1,6 +1,16 @@ > # The default target of this Makefile is... > all:: > > +# compile header > +.PHONY: hdr > +hdr:: abspath.h > + > +makeheaders: tools/makeheaders.c > + $(CC) -o $@ $< > + > +abspath.h: abspath.c makeheaders > + ./makeheaders $< This will break cross-compilation. At the very least, we needs to use either HOSTCC (likes linux project), HOST_CC or CC_FOR_BUILD (GNU Autotools' convention) to compile makeheaders So, something like (not tested, whatsoever): CC_FOR_BUILD = $(CC) CFLAGS_FOR_BUILD = $(CFLAGS) LDFLAGS_FOR_BUILD = $(LDFLAGS) QUIET_HOSTCC = echo ' ' HOSTCC $@; QUIET_MAKEHEADERS = echo ' ' MAKEHEADERS $@; makeheaders: tools/makeheaders.c $(QUIET_HOSTCC)$(CC_FOR_BUILD) -o $@ $(CFLAGS_FOR_BUILD) $(LDFLAGS_FOR_BUILD) $< abspath.h: abspath.c makeheaders $(QUIET_MAKEHEADERS)./makeheaders $< -- Danh