From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Taylor Blau" <me@ttaylorr.com>,
git@vger.kernel.org, derrickstolee@github.com, vdye@github.com
Subject: Re: [PATCH] builtin/repack.c: remove redundant pack-based bitmaps
Date: Mon, 17 Oct 2022 17:40:33 -0400 [thread overview]
Message-ID: <Y03L0W6TadyhtDij@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqlepeyxf6.fsf@gitster.g>
On Mon, Oct 17, 2022 at 02:04:13PM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > Really, both here and remove_redundant_pack() should probably be using
> > unlink_or_warn(). Though if you did want to notice the race on deleting
> > the actual .pack file, it would need to be hand-coded.
>
> Yeah, unlink_or_warn() would probably be the right way to go.
>
> Other than that, the patch looks good to you folks?
Yeah. I suggested a minor reordering of the one change, but the
substance of the patch looks good to me (and I am OK either way on the
little suggestions).
-Peff
next prev parent reply other threads:[~2022-10-17 21:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 19:05 [PATCH] builtin/repack.c: remove redundant pack-based bitmaps Taylor Blau
2022-10-17 18:02 ` Jeff King
2022-10-17 18:50 ` Ævar Arnfjörð Bjarmason
2022-10-17 19:27 ` Jeff King
2022-10-17 21:04 ` Junio C Hamano
2022-10-17 21:40 ` Jeff King [this message]
2022-10-18 2:38 ` Taylor Blau
2022-10-18 2:43 ` Taylor Blau
2022-10-18 2:45 ` [PATCH v2] " Taylor Blau
2022-10-18 6:29 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y03L0W6TadyhtDij@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).