From: Taylor Blau <me@ttaylorr.com>
To: Jeff King <peff@peff.net>
Cc: Matheus Tavares <matheus.bernardino@usp.br>, git@vger.kernel.org
Subject: Re: [PATCH] dir-iterator: drop unused `DIR_ITERATOR_FOLLOW_SYMLINKS`
Date: Thu, 16 Feb 2023 15:03:01 -0500 [thread overview]
Message-ID: <Y+6L9R9HkkUc7PkX@nand.local> (raw)
In-Reply-To: <Y+560+/G4pelldXF@coredump.intra.peff.net>
On Thu, Feb 16, 2023 at 01:49:55PM -0500, Jeff King wrote:
> Thanks for following up on this. I think it's an obviously good
> direction, and the patch looks sensible. It's hard to grep for
> --follow-symlinks or FOLLOW_SYMLINKS to make sure you got everything,
> just because there are other unrelated features that use that name. ;)
No problem.
> But...that is true even before your patch. dir5 is not mentioned in any
> of the expected output, even in fa1da7d2ee (dir-iterator: add flags
> parameter to dir_iterator_begin, 2019-07-10) where it was added. Was it
> just vestigial? Or is it somehow important that it is _not_ in the
> output?
>
> I didn't dig, and even if it can be removed, it would probably make
> sense to do it separately from your patch anyway.
I have no idea either. From a cursory scan, I think I'd err on the side
of it being vestigial. But Matheus (cc'd) should be able to tell us for
sure.
Thanks,
Taylor
next prev parent reply other threads:[~2023-02-16 20:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 18:27 [PATCH] dir-iterator: drop unused `DIR_ITERATOR_FOLLOW_SYMLINKS` Taylor Blau
2023-02-16 18:49 ` Jeff King
2023-02-16 20:03 ` Taylor Blau [this message]
2023-02-16 20:05 ` Taylor Blau
2023-02-17 0:16 ` Matheus Tavares Bernardino
2023-02-17 0:40 ` [PATCH 2/1] t0066: drop setup of "dir5" Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+6L9R9HkkUc7PkX@nand.local \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=matheus.bernardino@usp.br \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).