From: Eric Sunshine <sunshine@sunshineco.com>
To: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] developer: remove gcc 12 workaround
Date: Tue, 25 Apr 2023 23:45:42 -0400 [thread overview]
Message-ID: <CAPig+cSN=DYXuCmO4-ewN20mibqH7o+zESDbwXG8c0QW0TVVrA@mail.gmail.com> (raw)
In-Reply-To: <20230426013428.53206-1-carenas@gmail.com>
On Tue, Apr 25, 2023 at 9:47 PM Carlo Marcelo Arenas Belón
<carenas@gmail.com> wrote:
> Since 846a29afb0 (config.mak.dev: workaround gcc 12 bug affecting
> "pedantic" CI job, 2022-04-15), DEVELOPER mode has this workaround
> for the version of gcc that was released with Fedora 36.
>
> That version of Fedora is about to be EOL and latest versions of
> the compiler don't have that bug anymore, so remove the workaround.
>
> Tested not to trigger with latest gcc packages from the last 3
> Fedora releases, including gcc 13 from Fedora 38.
The commit message doesn't explain the benefit of removing this
workaround. Is it because it's a maintenance burden? Or is it
preventing some future planned improvement in this area? What is the
justification for penalizing users who might be stuck on Fedora 36 for
some reason or another?
(I ask these questions as a person who regularly is stuck on old
platforms for which it is increasingly painful or impossible to build
or install modern software.)
> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
> ---
> diff --git a/config.mak.dev b/config.mak.dev
> index 981304727c..6d07ef3692 100644
> --- a/config.mak.dev
> +++ b/config.mak.dev
> @@ -94,9 +94,4 @@ endif
> endif
> endif
>
> -# https://bugzilla.redhat.com/show_bug.cgi?id=2075786
> -ifneq ($(filter gcc12,$(COMPILER_FEATURES)),)
> -DEVELOPER_CFLAGS += -Wno-error=stringop-overread
> -endif
> -
> GIT_TEST_PERL_FATAL_WARNINGS = YesPlease
next prev parent reply other threads:[~2023-04-26 3:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 1:34 [PATCH] developer: remove gcc 12 workaround Carlo Marcelo Arenas Belón
2023-04-26 3:45 ` Eric Sunshine [this message]
2023-04-26 6:41 ` Carlo Arenas
2023-04-26 15:00 ` Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cSN=DYXuCmO4-ewN20mibqH7o+zESDbwXG8c0QW0TVVrA@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).