From: Eric Sunshine <sunshine@sunshineco.com>
To: "Martin Ågren" <martin.agren@gmail.com>
Cc: Sarah Julia Kriesch <sarah.kriesch@opensuse.org>,
git@vger.kernel.org, andreas.stieger@gmx.de
Subject: Re: git can not be built for s390x since update to git-2.38.0
Date: Tue, 1 Nov 2022 18:03:16 -0400 [thread overview]
Message-ID: <CAPig+cS184iKk6icG6ML=X+6Ng=fJyfic8izFyp1hT40cChm4g@mail.gmail.com> (raw)
In-Reply-To: <CAN0heSoc+jKxseyyR-=8+ATc8rdY5UyFWZPepaQsGn9m+Hpfmg@mail.gmail.com>
On Tue, Nov 1, 2022 at 3:41 PM Martin Ågren <martin.agren@gmail.com> wrote:
> On Tue, 1 Nov 2022 at 20:05, Martin Ågren <martin.agren@gmail.com> wrote:
> > > There is no real test error output, but we can identify, that it is
> > > happening in the test part with check-chainlint.
> >
> > > [ 387s] make[1]: *** [Makefile:83: check-chainlint] Error 1
>
> On further reading, it appears this error happens in the
> "check-chainlint" target without even checking this environment variable
> (that happens elsewhere). I doubt my original suggestion will be a
> complete workaround.
>
> One approach might be to patch the "check-chainlint" target into a
> no-op, possibly combined with turning off the chainlinting as I
> mentioned above. My makefile-foo is unfortunately not sufficiently
> advanced to immediately spot what might be going on here.
>
> At any rate, all of the above is just about working around the issue. As
> for a proper fix, let's hope someone like Eric can chime in.
Makefile-foo or not, there isn't much to go on here since the `make`
output doesn't show the actual problem. Squinting at the
`check-chainlint` target in "t/Makefile", I wonder if the problem is
with the line-splicing and missing command termination; that is, it
could just be a shell syntax error which is picked up by more strict
shells such as `dash`. In particular, in this hunk of code:
{ \
echo "# chainlint: $(CHAINLINTTMP_SQ)/tests" && \
for i in $(CHAINLINTTESTS); do \
echo "# chainlint: $$i" && \
sed -e '/^[ ]*$$/d' chainlint/$$i.expect; \
done \
} >'$(CHAINLINTTMP_SQ)'/expect && \
if you add a semicolon after `done` like this:
done; \
does that fix the problem?
If not, then you may want to remove the "@" from the "@mkdir -p ..."
in the body of the `check-chainlint` rule in t/Makefile so that `make`
will print out the actual command(s) it is running, and then invoke
the target manually with `make -C t check-chainlint`. With the actual
commands visible, copy/paste in the terminal to run each command
individually and check the exit status $? after each command
invocation to find which, if any, is failing.
next prev parent reply other threads:[~2022-11-01 22:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 18:04 git can not be built for s390x since update to git-2.38.0 Sarah Julia Kriesch
2022-11-01 19:05 ` Martin Ågren
2022-11-01 19:38 ` Taylor Blau
2022-11-01 19:41 ` Martin Ågren
2022-11-01 22:03 ` Eric Sunshine [this message]
2022-11-02 18:49 ` Todd Zullinger
-- strict thread matches above, loose matches on Subject: below --
2022-11-06 18:32 Sarah Julia Kriesch
2022-11-06 19:15 ` Sarah Julia Kriesch
2022-11-06 20:42 ` Eric Sunshine
2022-11-07 0:42 ` Todd Zullinger
2022-11-22 18:21 ` Eric Sunshine
2022-11-07 0:41 ` Todd Zullinger
[not found] <4657a19c-89c3-2237-9e6b-db897a492072@opensuse.org>
2022-11-21 5:12 ` Eric Sunshine
2022-11-22 14:35 ` Ævar Arnfjörð Bjarmason
2022-11-22 16:16 ` Eric Sunshine
2022-11-22 22:01 ` Ævar Arnfjörð Bjarmason
2022-11-22 22:20 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cS184iKk6icG6ML=X+6Ng=fJyfic8izFyp1hT40cChm4g@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=andreas.stieger@gmx.de \
--cc=git@vger.kernel.org \
--cc=martin.agren@gmail.com \
--cc=sarah.kriesch@opensuse.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).