From: Christian Couder <christian.couder@gmail.com>
To: John Cai via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, John Cai <johncai86@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2] attr: teach "--attr-source=<tree>" global option to "git"
Date: Thu, 27 Apr 2023 16:07:05 +0200 [thread overview]
Message-ID: <CAP8UFD3pqk1LrdA=FuRbfT+xHs4iBa6SxwmHUa1R7mXH5MmH-A@mail.gmail.com> (raw)
In-Reply-To: <CAP8UFD1YG-NnHbG4kBmh7L=O3wVnYKHCd94xD6Up_+AwK1ABPQ@mail.gmail.com>
On Thu, Apr 27, 2023 at 4:02 PM Christian Couder
<christian.couder@gmail.com> wrote:
> > - Add an environment variable GIT_ATTR_SOURCE that is set when
> > - --attr-source is passed in, so that subprocesses use the same value for
> > - the attributes source tree.
> > + Additionally, add an environment variable GIT_ATTR_SOURCE that is set
> > + when --attr-source is passed in, so that subprocesses use the same value
> > + for the attributes source tree.
> >
> > - Signed-off-by: Junio C Hamano <gitster@pobox.com>
> > Signed-off-by: John Cai <johncai86@gmail.com>
>
> If the patch is from Junio, I think you should keep his Signed-off-by. If you
I wanted to say that if you take ownership of the patch as Junio
suggested, I think it should be Ok either way.
next prev parent reply other threads:[~2023-04-27 14:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-18 3:25 [PATCH] attr: teach "--attr-source=<tree>" global option to "git" John Cai via GitGitGadget
2023-03-27 17:02 ` [PATCH v2] " John Cai via GitGitGadget
2023-03-27 18:29 ` Junio C Hamano
2023-03-27 19:40 ` John Cai
2023-04-27 14:02 ` Christian Couder
2023-04-27 14:07 ` Christian Couder [this message]
2023-04-28 18:50 ` [PATCH v3] " John Cai via GitGitGadget
2023-04-28 20:22 ` Christian Couder
2023-04-30 2:22 ` John Cai
2023-04-30 2:39 ` [PATCH v4] " John Cai via GitGitGadget
2023-05-01 16:21 ` Junio C Hamano
2023-05-03 15:10 ` Christian Couder
2023-05-03 18:40 ` John Cai
2023-05-03 20:09 ` [PATCH v5] " John Cai via GitGitGadget
2023-05-04 9:50 ` Christian Couder
2023-05-06 4:15 ` [PATCH v6] " John Cai via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP8UFD3pqk1LrdA=FuRbfT+xHs4iBa6SxwmHUa1R7mXH5MmH-A@mail.gmail.com' \
--to=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=johncai86@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).