From: Christian Couder <christian.couder@gmail.com>
To: Kousik Sanagavarapu <five231003@gmail.com>
Cc: git@vger.kernel.org, Hariom Verma <hariom18599@gmail.com>,
Jaydeep Das <jaydeepjd.8914@gmail.com>,
Nsengiyumva Wilberforce <nsengiyumvawilberforce@gmail.com>
Subject: Re: [PATCH 2/2] ref-filter: add new "signature" atom
Date: Thu, 1 Jun 2023 10:58:53 +0200 [thread overview]
Message-ID: <CAP8UFD0zQoc9zgMLdxNavMmPyjk5Orp1PDx5gpDEyuv5sv7h8w@mail.gmail.com> (raw)
In-Reply-To: <20230529192209.17747-3-five231003@gmail.com>
On Mon, May 29, 2023 at 9:23 PM Kousik Sanagavarapu
<five231003@gmail.com> wrote:
> +test_expect_success GPG 'setup: signature gpg' '
Maybe something like "setup: sign some commits using gpg" or "setup
for signature atom using gpg" would be a bit clearer.
> +test_expect_success GPGSSH 'setup: signature ssh' '
Here also something like "setup: sign some commits using ssh" or
"setup for signature atom using ssh" would be a bit clearer.
> + test_config gpg.format ssh &&
> + test_config user.signingkey "${GPGSSH_KEY_PRIMARY}" &&
I wonder if this test should try to clean up the config a bit after
itself. The previous test used:
`test_when_finished "test_unconfig commit.gpgSign"`
and maybe this one could do something similar.
> + echo "8" >file &&
> + test_tick &&
> + git commit -a -S -m "file: 8" &&
> + git tag eighth-signed-ssh
> +'
> +
> +test_expect_success GPG2 'bare signature atom' '
> + git verify-commit first-signed 2>out.raw &&
> + grep -Ev "checking the trustdb|PGP trust model" out.raw >out &&
> + head -3 out >expect &&
> + tail -1 out >>expect &&
> + echo "" >>expect &&
`echo >>expect` is more common to add a new line.
> + git for-each-ref refs/tags/first-signed \
> + --format="%(signature)" >actual &&
> + test_cmp expect actual
> +'
next prev parent reply other threads:[~2023-06-01 8:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-29 18:32 [GSoC][PATCH 0/2] Add new "signature" atom Kousik Sanagavarapu
2023-05-29 18:32 ` [PATCH 1/2] t/lib-gpg: introduce new prereq GPG2 Kousik Sanagavarapu
2023-06-01 8:39 ` Christian Couder
2023-05-29 18:32 ` [PATCH 2/2] ref-filter: add new "signature" atom Kousik Sanagavarapu
2023-06-01 8:58 ` Christian Couder [this message]
2023-06-01 9:11 ` [GSoC][PATCH 0/2] Add " Christian Couder
2023-06-02 2:11 ` [PATCH v2 " Kousik Sanagavarapu
2023-06-02 2:11 ` [PATCH v2 1/2] t/lib-gpg: introduce new prereq GPG2 Kousik Sanagavarapu
2023-06-02 6:50 ` Christian Couder
2023-06-02 12:58 ` Kousik Sanagavarapu
2023-06-02 2:11 ` [PATCH v2 2/2] ref-filter: add new "signature" atom Kousik Sanagavarapu
2023-06-02 8:23 ` Oswald Buddenhagen
2023-06-02 7:29 ` [PATCH v2 0/2] Add " Junio C Hamano
2023-06-02 7:51 ` Eric Sunshine
2023-06-03 0:16 ` Junio C Hamano
2023-06-02 13:13 ` Kousik Sanagavarapu
2023-06-04 18:22 ` [PATCH v3 " Kousik Sanagavarapu
2023-06-04 18:22 ` [PATCH v3 1/2] t/lib-gpg: introduce new prereq GPG2 Kousik Sanagavarapu
2023-06-04 18:22 ` [PATCH v3 2/2] ref-filter: add new "signature" atom Kousik Sanagavarapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP8UFD0zQoc9zgMLdxNavMmPyjk5Orp1PDx5gpDEyuv5sv7h8w@mail.gmail.com \
--to=christian.couder@gmail.com \
--cc=five231003@gmail.com \
--cc=git@vger.kernel.org \
--cc=hariom18599@gmail.com \
--cc=jaydeepjd.8914@gmail.com \
--cc=nsengiyumvawilberforce@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).