From: Christian Couder <christian.couder@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
John Cai <johncai86@gmail.com>, Patrick Steinhardt <ps@pks.im>
Subject: Re: [PATCH v2 0/3] upload-pack: support a missing-action
Date: Wed, 15 May 2024 15:59:59 +0200 [thread overview]
Message-ID: <CAP8UFD0hGoU_BKDq8+o6J9AT9jQOSRKrRw532MeMXTYebd3rHw@mail.gmail.com> (raw)
In-Reply-To: <20240515132543.851987-1-christian.couder@gmail.com>
Sorry everyone, it looks like I put the wrong message Id in the
--in-reply-to= option of my `git send-email` command and this appears
to be part of a different thread. The right message ID should have
been:
20240418184043.2900955-1-christian.couder@gmail.com
Sorry again.
On Wed, May 15, 2024 at 3:25 PM Christian Couder
<christian.couder@gmail.com> wrote:
>
> `git pack-objects` already supports a `--missing=<missing-action>`
> option, so that it can avoid erroring out if some objects aren't
> available.
>
> It is interesting to have `git upload-pack` support a similar way to
> avoid sending some objects in case they aren't available on the
> server.
>
> For example, in case both the server and the client are using a
> separate promisor remote that contain some objects, it can be better
> if the server doesn't try to send such objects back to the client, but
> instead let the client get those objects separately from the promisor
> remote. (The client needs to have the separate promisor remote
> configured, for that to work.)
>
> This could work better if there was something, like perhaps a
> capability, for the client to tell the server something like:
>
> "I know how to fetch missing objects from this and that
> promisor remotes, so if you choose to, you may omit objects
> that you know are available from these promisor remotes when
> sending objects to me."
>
> But that capability could be added later as other similar capabilities
> in this area could be very useful. For example in case of a client
> cloning, something like the following is currently needed:
>
> GIT_NO_LAZY_FETCH=0 git clone
> -c remote.my_promisor.promisor=true \
> -c remote.my_promisor.fetch="+refs/heads/*:refs/remotes/my_promisor/*" \
> -c remote.my_promisor.url=<MY_PROMISOR_URL> \
> --filter="blob:limit=5k" server
>
> But it would be nice if there was a capability for the client to say
> that it would like the server to give it information about the
> promisor that it could use, so that the user doesn't have to pass all
> the "remote.my_promisor.XXX" config options on the command like. (It
> would then be a bit similar to the bundle-uri feature where all the
> bundle related information comes from the server.)
>
> Another example use of this feature could be a server where some
> objects have been corrupted or deleted. It could still be useful for
> clients who could get those objects from another source, like perhaps
> a different client, to be able to fetch or clone from the server.
>
> The fact that the new `uploadpack.missingAction` configuration
> variable has to be set to a non default value on the server means that
> regular client users cannot hurt themselves with this feature.
>
> As `git rev-list` also supports a `--missing=<missing-action>` option,
> the first 2 patches in this series are about refactoring related code
> from both `git rev-list` and `git pack-objects` into new
> "missing.{c,h}" files. Patch 3/3 then adds a new
> `uploadpack.missingAction` configuration variable.
>
> The changes since v1 are the following:
>
> - In patch 1/3 the refactored parse_missing_action_value() function
> doesn't change the fetch_if_missing global variable anymore. The
> clients of this function change it by themselves instead.
>
> - In patch 1/3 a minor typo was also fixed.
>
> - Old patch 2/4 that added a 'int print_ok' argument to
> parse_missing_action_value() was removed, and now callers deal
> with only the values they recognise.
>
> Thanks to Junio for his review and for suggesting of the above
> changes.
>
> Christian Couder (3):
> rev-list: refactor --missing=<missing-action>
> pack-objects: use the missing action API
> upload-pack: allow configuring a missing-action
>
> Documentation/config/uploadpack.txt | 9 ++
> Makefile | 1 +
> builtin/pack-objects.c | 48 ++++++-----
> builtin/rev-list.c | 43 ++--------
> missing.c | 36 ++++++++
> missing.h | 19 +++++
> t/t5706-upload-pack-missing.sh | 125 ++++++++++++++++++++++++++++
> upload-pack.c | 19 +++++
> 8 files changed, 242 insertions(+), 58 deletions(-)
> create mode 100644 missing.c
> create mode 100644 missing.h
> create mode 100755 t/t5706-upload-pack-missing.sh
>
> --
> 2.45.1.148.g0f5efb064b
>
prev parent reply other threads:[~2024-05-15 14:00 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 13:51 [PATCH 0/3] Implement filtering repacks Christian Couder
2022-10-12 13:51 ` [PATCH 1/3] pack-objects: allow --filter without --stdout Christian Couder
2022-10-12 13:51 ` [PATCH 2/3] repack: add --filter=<filter-spec> option Christian Couder
2022-10-12 13:51 ` [PATCH 3/3] repack: introduce --force to force filtering Christian Couder
2022-10-14 16:46 ` [PATCH 0/3] Implement filtering repacks Junio C Hamano
2022-10-20 11:23 ` Christian Couder
2022-10-28 19:49 ` Taylor Blau
2022-10-28 20:26 ` Junio C Hamano
2022-11-07 9:12 ` Christian Couder
2022-11-07 9:00 ` Christian Couder
2022-10-25 12:28 ` [PATCH v2 0/2] " Christian Couder
2022-10-25 12:28 ` [PATCH v2 1/2] pack-objects: allow --filter without --stdout Christian Couder
2022-10-25 12:28 ` [PATCH v2 2/2] repack: add --filter=<filter-spec> option Christian Couder
2022-10-28 19:54 ` [PATCH v2 0/2] Implement filtering repacks Taylor Blau
2022-11-07 9:29 ` Christian Couder
2022-11-22 17:51 ` [PATCH v3 " Christian Couder
2022-11-22 17:51 ` [PATCH v3 1/2] pack-objects: allow --filter without --stdout Christian Couder
2022-11-22 17:51 ` [PATCH v3 2/2] repack: add --filter=<filter-spec> option Christian Couder
2022-11-23 0:31 ` [PATCH v3 0/2] Implement filtering repacks Junio C Hamano
2022-12-21 3:53 ` Christian Couder
2022-11-23 0:35 ` Junio C Hamano
2022-12-21 4:04 ` [PATCH v4 0/3] " Christian Couder
2022-12-21 4:04 ` [PATCH v4 1/3] pack-objects: allow --filter without --stdout Christian Couder
2023-01-04 14:56 ` Patrick Steinhardt
2022-12-21 4:04 ` [PATCH v4 2/3] repack: add --filter=<filter-spec> option Christian Couder
2023-01-04 14:56 ` Patrick Steinhardt
2023-01-05 1:39 ` Junio C Hamano
2022-12-21 4:04 ` [PATCH v4 3/3] gc: add gc.repackFilter config option Christian Couder
2023-01-04 14:57 ` Patrick Steinhardt
2024-05-15 13:25 ` [PATCH v2 0/3] upload-pack: support a missing-action Christian Couder
2024-05-15 13:25 ` [PATCH v2 1/3] rev-list: refactor --missing=<missing-action> Christian Couder
2024-05-15 16:16 ` Junio C Hamano
2024-05-15 13:25 ` [PATCH v2 2/3] pack-objects: use the missing action API Christian Couder
2024-05-15 16:46 ` Junio C Hamano
2024-05-24 16:40 ` Christian Couder
2024-05-15 13:25 ` [PATCH v2 3/3] upload-pack: allow configuring a missing-action Christian Couder
2024-05-15 17:08 ` Junio C Hamano
2024-05-24 16:41 ` Christian Couder
2024-05-24 21:51 ` Junio C Hamano
2024-05-28 10:10 ` Christian Couder
2024-05-28 15:54 ` Junio C Hamano
2024-05-31 20:43 ` Christian Couder
2024-06-01 9:43 ` Junio C Hamano
2024-05-15 13:59 ` Christian Couder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP8UFD0hGoU_BKDq8+o6J9AT9jQOSRKrRw532MeMXTYebd3rHw@mail.gmail.com \
--to=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johncai86@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).