Git Mailing List Archive mirror
 help / color / mirror / Atom feed
From: "Alejandro R. Sedeño" <asedeno@mit.edu>
To: Git List <git@vger.kernel.org>
Cc: newren@gmail.com
Subject: Problems with 592fc5b349
Date: Thu, 1 Jun 2023 09:47:27 -0400	[thread overview]
Message-ID: <CAOO-Oz2ua31xDOA9hdE-mMx3qwctDHK6Tu6AKdGc1_beuJMkwA@mail.gmail.com> (raw)

592fc5b3495bf4ff17252d31109f1d9c0134684b moved backup definitions of

  #define DT_

from cache.h to dir.h, but did not include dir.h in cache.h despite those
#defines being used there. Easy fix, `#include "dir.h"` in cache.h,
which I'd submit as a patch, but then name-hash.c, which includes
cache.h, which would now include dir.h, ends up with two definitions
of `struct dir_entry`.

Suggestions?

-Alejandro

             reply	other threads:[~2023-06-01 13:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-01 13:47 Alejandro R. Sedeño [this message]
2023-06-01 14:33 ` Problems with 592fc5b349 Elijah Newren
2023-06-01 15:20   ` Alejandro R. Sedeño

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOO-Oz2ua31xDOA9hdE-mMx3qwctDHK6Tu6AKdGc1_beuJMkwA@mail.gmail.com \
    --to=asedeno@mit.edu \
    --cc=git@vger.kernel.org \
    --cc=newren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).