From: Karthik Nayak <karthik.188@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, chris.torek@gmail.com
Subject: Re: [PATCH 1/2] update-ref: use {old,new}-oid instead of {old,new}value
Date: Mon, 1 Apr 2024 23:50:11 -0700 [thread overview]
Message-ID: <CAOLa=ZS1OUCtPTC2LGpgU0K7U-ryNkkKFLrUqnuz=tcpU0NE-g@mail.gmail.com> (raw)
In-Reply-To: <xmqqr0fo7kop.fsf@gitster.g>
[-- Attachment #1: Type: text/plain, Size: 506 bytes --]
Junio C Hamano <gitster@pobox.com> writes:
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>>> Did you run t1400 after this update? There may be other tests that
>>> the message update is breaking but that was the first one I noticed.
>>
>> I definitely didn't. It totally slipped my mind, I was thinking that I
>> only modified the *.txt files. I will send in a new version after
>> ensuring all tests are fixed.
>
> Here is what I have.
>
Yup, this should fix it. I've sent in v2 with the same fix.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 690 bytes --]
next prev parent reply other threads:[~2024-04-02 6:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 14:45 [PATCH 0/2] improve documentation around git-update-ref Karthik Nayak
2024-04-01 14:45 ` [PATCH 1/2] update-ref: use {old,new}-oid instead of {old,new}value Karthik Nayak
2024-04-01 20:51 ` Junio C Hamano
2024-04-01 22:38 ` Karthik Nayak
2024-04-01 23:00 ` Junio C Hamano
2024-04-02 6:50 ` Karthik Nayak [this message]
2024-04-01 14:45 ` [PATCH 2/2] githooks: use {old,new}-oid instead of {old,new}-value Karthik Nayak
2024-04-02 6:49 ` [PATCH v2 0/2] improve documentation around git-update-ref Karthik Nayak
2024-04-02 6:49 ` [PATCH v2 1/2] update-ref: use {old,new}-oid instead of {old,new}value Karthik Nayak
2024-04-02 6:49 ` [PATCH v2 2/2] githooks: use {old,new}-oid instead of {old,new}-value Karthik Nayak
2024-04-02 6:56 ` [PATCH v2 0/2] improve documentation around git-update-ref Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOLa=ZS1OUCtPTC2LGpgU0K7U-ryNkkKFLrUqnuz=tcpU0NE-g@mail.gmail.com' \
--to=karthik.188@gmail.com \
--cc=chris.torek@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).