From: ZheNing Hu <adlternative@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "ZheNing Hu via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Martin Monperrus" <martin.monperrus@gnieh.org>
Subject: Re: [PATCH 1/2] ls-files: add %(objecttype) atom to format option
Date: Thu, 18 May 2023 18:02:43 +0800 [thread overview]
Message-ID: <CAOLTT8TEN38j8k6fnzcTs3X_a7yTrKysi50Nt7sH2bdbgWkwEA@mail.gmail.com> (raw)
In-Reply-To: <xmqqednicho7.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> 于2023年5月15日周一 13:00写道:
>
> "ZheNing Hu via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > From: ZheNing Hu <adlternative@gmail.com>
> >
> > Sometimes users may want to align the feature of
> > `git ls-files --format` with that of `git ls-tree --format`,
> > but the %(objecttype) atom is missing in the format option
> > of git ls-files compared to git ls-tree.
>
> "Sometimes users may want to" sounds a bit awkward; even if no user
> notices that the two very similar commands supports different subset
> of the vocabulary without good reason, wouldn't we want to align the
> feature set of these two commands?
>
> > Therefore, the %(objecttype) atom is added to the format option
> > of git ls-files, which can be used to obtain the object type
> > of the file which is recorded in the index.
>
> And from that point of view, this conclusion has a bit more to think
> about. Is the %(objecttype) singled out here only because somebody
> happened to have complained on the list, or did somebody went into
> the list of supported atoms between two commands and considered what
> is missing from one but is supported by the other, and concluded that
> only adding this one atom to ls-files would make the two consistent?
>
> I would not complain if it were the former, but it must be explained
> here in the proposed log message. That would encourage others to do
> a follow-on work to complete the comparison to fill the gaps on the
> both sides. If it were the former, saying so explicitly in the
> proposed log message will save others---otherwise they may try to do
> the comparison themselves only to find that this was the last one
> remaining discrepancy.
>
I think the original requirement is that users wanted to obtain a similar
output format to the default output format of git ls-tree directly through
git ls-files --format="%(objectmode) %(objecttype) %(objectname)%x09%(path)",
but found that the corresponding functionality was missing.
However, from a deeper perspective, the results displayed by git ls-files
for the index and git ls-tree -r for the tree are very similar. Making
git ls-files compatible with the atoms of git ls-tree can provide a
unified view here,
and can also be used for some conversion between the index and tree, such as
git ls-files --format | git mktree.
next prev parent reply other threads:[~2023-05-18 10:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-13 9:11 [PATCH 0/2] ls-files: align format atoms with git ls-tree ZheNing Hu via GitGitGadget
2023-05-13 9:11 ` [PATCH 1/2] ls-files: add %(objecttype) atom to format option ZheNing Hu via GitGitGadget
2023-05-15 5:00 ` Junio C Hamano
2023-05-18 10:02 ` ZheNing Hu [this message]
2023-05-13 9:11 ` [PATCH 2/2] ls-files: add %(objectsize) " ZheNing Hu via GitGitGadget
2023-05-15 5:03 ` Junio C Hamano
2023-05-23 9:00 ` [PATCH v2] ls-files: aligin format atoms wtih ls-tree ZheNing Hu via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOLTT8TEN38j8k6fnzcTs3X_a7yTrKysi50Nt7sH2bdbgWkwEA@mail.gmail.com \
--to=adlternative@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=martin.monperrus@gnieh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).