* [PATCH] ls-files: fix black space in error message
@ 2022-09-11 14:03 ZheNing Hu via GitGitGadget
2022-09-12 16:24 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: ZheNing Hu via GitGitGadget @ 2022-09-11 14:03 UTC (permalink / raw)
To: git; +Cc: Junio C Hamano, Jiang Xin, ZheNing Hu, ZheNing Hu
From: ZheNing Hu <adlternative@gmail.com>
ce74de9(ls-files: introduce "--format" option) miss
a space between two words incorrectly, it leads to
wrong i10n messages. So fix it by adding a space at
the end of the error message.
Signed-off-by: ZheNing Hu <adlternative@gmail.com>
---
ls-files: fix black space in error message
This patch want fix a little typo error in builtin/ls-files.c, which
pointed out by Jiang Xin in [1].
[1]:
https://lore.kernel.org/git/CANYiYbFGSfg+iFV1ovhCSxW0YQSpemKUN-sS+F0BHee7KD5arA@mail.gmail.com/.
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1350%2Fadlternative%2Fzh%2Fls-file-format-error-mesage-fix-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1350/adlternative/zh/ls-file-format-error-mesage-fix-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1350
builtin/ls-files.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/ls-files.c b/builtin/ls-files.c
index 779dc18e59d..4cf8a236483 100644
--- a/builtin/ls-files.c
+++ b/builtin/ls-files.c
@@ -257,7 +257,7 @@ static size_t expand_show_index(struct strbuf *sb, const char *start,
end = strchr(start + 1, ')');
if (!end)
- die(_("bad ls-files format: element '%s'"
+ die(_("bad ls-files format: element '%s' "
"does not end in ')'"), start);
len = end - start + 1;
base-commit: dd3f6c4cae7e3b15ce984dce8593ff7569650e24
--
gitgitgadget
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ls-files: fix black space in error message
2022-09-11 14:03 [PATCH] ls-files: fix black space in error message ZheNing Hu via GitGitGadget
@ 2022-09-12 16:24 ` Junio C Hamano
2022-09-17 13:16 ` ZheNing Hu
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2022-09-12 16:24 UTC (permalink / raw)
To: ZheNing Hu via GitGitGadget; +Cc: git, Jiang Xin, ZheNing Hu
"ZheNing Hu via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: ZheNing Hu <adlternative@gmail.com>
> Subject: Re: [PATCH] ls-files: fix black space in error message
"black" -> "missing" perhaps? I'll queue with the reword for now
but if you have a better alternative please holler.
> ce74de9(ls-files: introduce "--format" option) miss a space
> between two words incorrectly, it leads to wrong i10n messages. So
> fix it by adding a space at the end of the error message.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ls-files: fix black space in error message
2022-09-12 16:24 ` Junio C Hamano
@ 2022-09-17 13:16 ` ZheNing Hu
0 siblings, 0 replies; 3+ messages in thread
From: ZheNing Hu @ 2022-09-17 13:16 UTC (permalink / raw)
To: Junio C Hamano; +Cc: ZheNing Hu via GitGitGadget, Git List, Jiang Xin
Junio C Hamano <gitster@pobox.com> 于2022年9月13日周二 00:24写道：
>
> "ZheNing Hu via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > From: ZheNing Hu <adlternative@gmail.com>
> > Subject: Re: [PATCH] ls-files: fix black space in error message
>
> "black" -> "missing" perhaps? I'll queue with the reword for now
> but if you have a better alternative please holler.
>
Use the "missing" is ok, thanks,
> > ce74de9(ls-files: introduce "--format" option) miss a space
> > between two words incorrectly, it leads to wrong i10n messages. So
> > fix it by adding a space at the end of the error message.
>
> Thanks.
ZheNing Hu
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-17 13:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-11 14:03 [PATCH] ls-files: fix black space in error message ZheNing Hu via GitGitGadget
2022-09-12 16:24 ` Junio C Hamano
2022-09-17 13:16 ` ZheNing Hu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).