* Re:[PATCH 1/1] [gsoc][patch] trace.c, git.c: removed unnecessary parameter to trace_repo_setup
@ 2023-02-15 17:17 Shuqi Liang
0 siblings, 0 replies; 2+ messages in thread
From: Shuqi Liang @ 2023-02-15 17:17 UTC (permalink / raw
To: git, 20230215104246.8919-2-mcsm224
Hello Idriss,
I have some suggestions：
Seen like you didn't describe the existing problem and how you fix it
in the commit message. You can start with a description of the
existing problem in the present tense in your commit message. Also,
you should use the imperative mood to describe the change you make.
Maybe you can write something like the below in your commit message
after you use git commit -s.
----------------------------------------------------------------------------------------
trace.c, git.c: removed unnecessary parameter to trace_repo_setup
your description of the existing problem.............
Fix them.
Signed-off-by: ...
-------------------------------------------------------------------------------------------
Regards,
Shuqi
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re:[PATCH 1/1] [gsoc][patch] trace.c, git.c: removed unnecessary parameter to trace_repo_setup
2023-02-15 10:42 [PATCH 1/1] remove parameter (prefix) from trace_repo_setup Idriss Fekir
@ 2023-02-15 17:55 ` Shuqi Liang
0 siblings, 0 replies; 2+ messages in thread
From: Shuqi Liang @ 2023-02-15 17:55 UTC (permalink / raw
To: git; +Cc: Shuqi Liang
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=y, Size: 766 bytes --]
Hello Idriss,
I have some suggestions：
Seen like you didn't describe the existing problem and how you fix it
in the commit message. You can start with a description of the
existing problem in the present tense in your commit message. Also,
you should use the imperative mood to describe the change you make.
Maybe you can write something like the below in your commit message
after you use git commit -s.
----------------------------------------------------------------------------------------
trace.c, git.c: removed unnecessary parameter to trace_repo_setup
your description of the existing problem.............
Fix them.
Signed-off-by: ...
-------------------------------------------------------------------------------------------
Regards,
Shuqi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-15 17:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-15 17:17 Re:[PATCH 1/1] [gsoc][patch] trace.c, git.c: removed unnecessary parameter to trace_repo_setup Shuqi Liang
-- strict thread matches above, loose matches on Subject: below --
2023-02-15 10:42 [PATCH 1/1] remove parameter (prefix) from trace_repo_setup Idriss Fekir
2023-02-15 17:55 ` Re:[PATCH 1/1] [gsoc][patch] trace.c, git.c: removed unnecessary parameter to trace_repo_setup Shuqi Liang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).