From: Han Xin <hanxin.hx@bytedance.com>
To: Derrick Stolee <derrickstolee@github.com>
Cc: git@vger.kernel.org, xingxin.xx@bytedance.com,
jonathantanmy@google.com, Junio C Hamano <gitster@pobox.com>
Subject: Re: [External] Re: [PATCH v2 1/2] negotiator/default: avoid stack overflow
Date: Wed, 26 Apr 2023 19:40:35 +0800 [thread overview]
Message-ID: <CAKgqsWV==tgyz8EOs61_06+bX4Eq+0Su1bocZ+-s4oe+e0DdJA@mail.gmail.com> (raw)
In-Reply-To: <bf45bfe7-4a29-38d6-b8d7-811581aec82b@github.com>
On Wed, Apr 26, 2023 at 7:13 PM Derrick Stolee <derrickstolee@github.com> wrote:
>
> On 4/26/2023 12:05 AM, Han Xin wrote:
> > mark_common() in negotiator/default.c may overflow the stack due to
> > recursive function calls. Avoid this by instead recursing using a
> > heap-allocated data structure.
> >
> > This is the same case as [1].
> >
> > 1. 4654134976f (negotiator/skipping: avoid stack overflow, 2022-10-25)
>
> We would typically write this inline, such as:
>
> This is the same case as 4654134976f (negotiator/skipping: avoid
> stack overflow, 2022-10-25)
>
Make sense.
Thanks
-Han Xin
next prev parent reply other threads:[~2023-04-26 11:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 2:23 [PATCH v1] negotiator/default.c: avoid stack overflow Han Xin
2023-04-24 14:44 ` Derrick Stolee
2023-04-25 3:02 ` [External] " Han Xin
2023-04-25 13:34 ` Derrick Stolee
2023-04-26 4:05 ` [PATCH v2 0/2] negotiator/default: " Han Xin
2023-04-26 4:05 ` [PATCH v2 1/2] " Han Xin
2023-04-26 11:13 ` Derrick Stolee
2023-04-26 11:40 ` Han Xin [this message]
2023-04-26 4:05 ` [PATCH v2 2/2] negotiator/skipping: fix some problems in mark_common() Han Xin
2023-04-26 11:08 ` Derrick Stolee
2023-04-26 11:55 ` [External] " Han Xin
2023-04-26 13:15 ` [PATCH v2 0/2] negotiator/default: avoid stack overflow Han Xin
2023-04-26 13:15 ` [PATCH v3 1/2] " Han Xin
2023-04-26 17:14 ` Junio C Hamano
2023-04-26 17:30 ` Derrick Stolee
2023-04-26 17:38 ` Junio C Hamano
2023-04-26 13:15 ` [PATCH v3 2/2] negotiator/skipping: fix some problems in mark_common() Han Xin
2023-05-01 22:11 ` [PATCH v2 0/2] negotiator/default: avoid stack overflow Junio C Hamano
2023-05-02 1:49 ` Derrick Stolee
2023-05-02 15:51 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKgqsWV==tgyz8EOs61_06+bX4Eq+0Su1bocZ+-s4oe+e0DdJA@mail.gmail.com' \
--to=hanxin.hx@bytedance.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
--cc=xingxin.xx@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).