Git Mailing List Archive mirror
 help / color / mirror / Atom feed
From: Matheus Tavares Bernardino <>
To: Taylor Blau <>
Cc: Jeff King <>,
Subject: Re: [PATCH] dir-iterator: drop unused `DIR_ITERATOR_FOLLOW_SYMLINKS`
Date: Thu, 16 Feb 2023 21:16:50 -0300	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <Y+6Mcnng0u6sz+C6@nand.local>

Hi, Taylor and Jeff

On Thu, Feb 16, 2023 at 5:05 PM Taylor Blau <> wrote:
> On Thu, Feb 16, 2023 at 03:03:01PM -0500, Taylor Blau wrote:
> > I have no idea either. From a cursory scan, I think I'd err on the side
> > of it being vestigial. But Matheus (cc'd) should be able to tell us for
> > sure.

Oh, it's been some time. But yes, dir5 is vestigial and should indeed
be removed. It was created back when I wanted to make dir-iterator
detect and avoid recursive symlinks (see this [1] earlier version of
the patch, where there was a test grepping for dir5 at the output).
But this idea ended up being discarded and I must have forgotten to
remove the dir5.


  reply	other threads:[~2023-02-17  0:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-16 18:27 [PATCH] dir-iterator: drop unused `DIR_ITERATOR_FOLLOW_SYMLINKS` Taylor Blau
2023-02-16 18:49 ` Jeff King
2023-02-16 20:03   ` Taylor Blau
2023-02-16 20:05     ` Taylor Blau
2023-02-17  0:16       ` Matheus Tavares Bernardino [this message]
2023-02-17  0:40         ` [PATCH 2/1] t0066: drop setup of "dir5" Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).