From: M Hickford <mirth.hickford@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "M Hickford via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org, "Eric Sunshine" <sunshine@sunshineco.com>,
"Jeff King" <peff@peff.net>, Cheetham <mjcheetham@outlook.com>,
Dennington <lessleydennington@gmail.com>,
"Martin Ågren" <martin.agren@gmail.com>,
"Calvin Wan" <calvinwan@google.com>,
"M Hickford" <mirth.hickford@gmail.com>
Subject: Re: [PATCH v2] credential: new attribute oauth_refresh_token
Date: Mon, 24 Apr 2023 21:11:47 +0100 [thread overview]
Message-ID: <CAGJzqsnAj-yHHY9-79WSF7gCNN-x6scrFkXMxC6xQQMHWeeuKw@mail.gmail.com> (raw)
In-Reply-To: <xmqqildpkwnb.fsf@gitster.g>
On Fri, 21 Apr 2023 at 17:50, Junio C Hamano <gitster@pobox.com> wrote:
>
> "M Hickford via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > Patch v2 adds an additional test
>
> What we have below shows some differences outside the test, but the
> range-diff I see locally does show that the change since v1 is
> purely to the tests.
Thank Junio for your reply. Yes I also rebased.
>
> > Documentation/git-credential.txt | 6 ++++++
> > builtin/credential-cache--daemon.c | 3 +++
> > credential.c | 6 ++++++
> > credential.h | 1 +
> > t/lib-credential.sh | 30 ++++++++++++++++++++++++++++++
> > t/t0300-credentials.sh | 18 ++++++++++++++++++
> > t/t0301-credential-cache.sh | 1 +
> > 7 files changed, 65 insertions(+)
>
> Will replace what I kept in 'seen'.
>
> The original unfortunately did not see anybody interested enough in
> the topic to review and comment. Let's hope this time is different
> ;-)
>
> THanks.
next prev parent reply other threads:[~2023-04-24 20:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 6:46 [PATCH] credential: new attribute oauth_refresh_token M Hickford via GitGitGadget
2023-04-21 9:47 ` [PATCH v2] " M Hickford via GitGitGadget
2023-04-21 16:50 ` Junio C Hamano
2023-04-24 20:11 ` M Hickford [this message]
2023-04-25 6:47 ` Jeff King
2023-04-25 19:19 ` M Hickford
2023-05-02 10:25 ` Jeff King
2023-05-02 16:19 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGJzqsnAj-yHHY9-79WSF7gCNN-x6scrFkXMxC6xQQMHWeeuKw@mail.gmail.com \
--to=mirth.hickford@gmail.com \
--cc=calvinwan@google.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=lessleydennington@gmail.com \
--cc=martin.agren@gmail.com \
--cc=mjcheetham@outlook.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).