From: Vivan Garg <v.garg.work@gmail.com>
To: Zhang Yi <18994118902@163.com>
Cc: git@vger.kernel.org
Subject: Re: [GSOC] [PATCH v1 1/2] Fix title style
Date: Wed, 22 Feb 2023 00:13:18 -0700 [thread overview]
Message-ID: <CADupsJMW8fRDvhknxFgnSRQ4O7+YDHkKsEBoFq-yhO2vCq5MBg@mail.gmail.com> (raw)
In-Reply-To: <20230222040745.1511205-2-18994118902@163.com>
You are missing the body of the commit message. Commit message
should start with description of the existing problem in present tense,
something like:
Test scripts in file t9700-perl-git.sh are written in old style,
where the test_expect_success command and test title are written on
separate lines ...
Then changes should be described using imperative mood, as if you are
giving commands to the codebase. See section "[[describe-changes]]"
in "Documentation/SubmittingPatches" for details.
> Signed-off-by: Zhang Yi <18994118902@163.com>
> ---
> t/t9700-perl-git.sh | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/t/t9700-perl-git.sh b/t/t9700-perl-git.sh
> index b105d6d9d5..3f6396ef63 100755
> --- a/t/t9700-perl-git.sh
> +++ b/t/t9700-perl-git.sh
> @@ -13,9 +13,8 @@ skip_all_if_no_Test_More
>
> # set up test repository
>
> -test_expect_success \
> - 'set up test repository' \
> - 'echo "test file 1" > file1 &&
> +test_expect_success 'set up test repository' '
> + echo "test file 1" > file1 &&
> echo "test file 2" > file2 &&
> mkdir directory1 &&
> echo "in directory1" >> directory1/file &&
> --
there should be no whitespace after redirect operators, so:
echo "test file 1" > file1 &&
should become:
echo "test file 1" >file1 &&
Similar changes for the rest of the test script as well.
> 2.29.0-rc0
>
next prev parent reply other threads:[~2023-02-22 7:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-22 4:07 [GSOC] [PATCH v1 0/2] Modernize t9700 test script Zhang Yi
2023-02-22 4:07 ` [GSOC] [PATCH v1 1/2] Fix title style Zhang Yi
2023-02-22 7:13 ` Vivan Garg [this message]
2023-02-22 4:07 ` [GSOC] [PATCH v1 2/2] Change indents to TAB Zhang Yi
2023-02-22 7:24 ` Vivan Garg
2023-02-22 7:09 ` [GSOC] [PATCH v1 0/2] Modernize t9700 test script Vivan Garg
2023-02-24 1:34 ` [GSOC] [PATCH v2 0/3] t9700:moderizen test scripts Zhang Yi
2023-02-24 1:34 ` [GSOC] [PATCH v2 1/3] t9700:fix title style Zhang Yi
2023-02-24 1:34 ` [GSOC] [PATCH v2 2/3] t9700:change indents to TAB Zhang Yi
2023-02-24 1:34 ` [GSOC] [PATCH v2 3/3] t9700:delete whitespaces after redirect operators Zhang Yi
2023-02-24 11:20 ` Philip Oakley
2023-02-24 2:49 ` [GSOC] [PATCH v2 0/3] t9700:moderizen test scripts Junio C Hamano
2023-02-24 3:31 ` Zhang Yi
2023-02-25 1:30 ` [GSOC] [PATCH v3 1/1] t9700: modernize " Zhang Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADupsJMW8fRDvhknxFgnSRQ4O7+YDHkKsEBoFq-yhO2vCq5MBg@mail.gmail.com \
--to=v.garg.work@gmail.com \
--cc=18994118902@163.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).