From: Sam James <sam@gentoo.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3 0/2] diff: copies-harder support
Date: Fri, 17 May 2024 04:38:15 +0100 [thread overview]
Message-ID: <87r0e1f6qg.fsf@gentoo.org> (raw)
In-Reply-To: <xmqq8r09u5u5.fsf@gitster.g> (Junio C. Hamano's message of "Thu, 16 May 2024 08:36:18 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Sam James <sam@gentoo.org> writes:
>
>> ping - let me know if I need to do anything different. Thanks!
>>
>>>>
>>>>
>>>>> Documentation/config/diff.txt | 8 +++++---
>>>>> Documentation/config/status.txt | 4 +++-
>>>>> diff.c | 14 +++++++++++---
>>>>> diff.h | 1 +
>>>>> diffcore-rename.c | 6 ++++--
>>>>> merge-ort.c | 2 +-
>>>>> merge-recursive.c | 2 +-
>>>>> 7 files changed, 26 insertions(+), 11 deletions(-)
>
> Copies-harder is supported from the command line already. We do not
> want a configuration variable for it. diff.renames configuration
> was already a mistake enough. Let's not pile on a new mistake on an
> old mistake that it is too late for us to take back.
Thanks for the reply. It's a shame that a conceptual NACK wasn't
delivered in v1 [0] though. Also, Elijah said a configuration option made
sense in v1 and you responded to him and didn't disagree, so I took it
as conceptually okay.
I'm aware of the command line option existing. It doesn't work well for
us because it's really only suitable for certain classes of repos where
you essentially *always* want it enabled (any ebuild repository), but
you don't otherwise given its speed and you may not even be
expecting many copies/renames elsewhere.
[0] https://lore.kernel.org/git/xmqq7cmu9s29.fsf@gitster.g/
>
> Thanks.
thanks,
sam
prev parent reply other threads:[~2024-05-17 3:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 21:38 [PATCH v3 0/2] diff: copies-harder support Sam James
2024-03-11 21:38 ` [PATCH v3 1/2] diff: implement config.diff.renames=copies-harder Sam James
2024-03-11 21:38 ` [PATCH v3 2/2] diff: whitespace cleanup Sam James
2024-04-08 15:32 ` [PATCH v3 0/2] diff: copies-harder support Sam James
2024-04-16 2:42 ` Sam James
2024-05-15 22:27 ` Sam James
2024-05-16 15:36 ` Junio C Hamano
2024-05-17 3:38 ` Sam James [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0e1f6qg.fsf@gentoo.org \
--to=sam@gentoo.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).