From: Junio C Hamano <junkio@cox.net>
To: "Lars Hjemli" <hjemli@gmail.com>
Cc: "Junio C Hamano" <junkio@cox.net>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org
Subject: Re: [PATCH] Add basic test-script for git-submodule
Date: Thu, 31 May 2007 20:54:14 -0700 [thread overview]
Message-ID: <7vzm3kz5w9.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <8c5c35580705292348q74281f7eu15b3b61f45b2c6f5@mail.gmail.com> (Lars Hjemli's message of "Wed, 30 May 2007 08:48:38 +0200")
"Lars Hjemli" <hjemli@gmail.com> writes:
> Would you prefer a patch on top of this version of the test-script or
> on top of the later patch which uses .git/config to store submodule
> url?
As you said you will be redoing submodule + .git/config stuff in
your other message, I would expect a replacement (i.e. not on
top of this) patch for tests to check the existing submodule
features. If you want to finish the submodule + .git/config one
first and then test script on top to test both existing featues
and submodule + .git/config features, that is fine as well.
Your choice.
One important point is to treat the test-script take #1 as
"already rejected", and not basing further patches on it.
next prev parent reply other threads:[~2007-06-01 3:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-27 20:34 [PATCH] Add basic test-script for git-submodule Lars Hjemli
2007-05-29 7:10 ` Junio C Hamano
2007-05-30 6:48 ` Lars Hjemli
2007-06-01 3:54 ` Junio C Hamano [this message]
2007-06-01 7:10 ` Lars Hjemli
2007-06-01 7:56 ` Johannes Sixt
2007-06-01 8:13 ` Lars Hjemli
2007-06-01 19:50 ` Junio C Hamano
2007-06-02 1:27 ` Lars Hjemli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vzm3kz5w9.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=hjemli@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).