Git Mailing List Archive mirror
 help / color / mirror / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: Chris Torek <chris.torek@gmail.com>,
	Pooyan Khanjankhani via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Pooyan Khanjankhani <pooyankhan@gmail.com>,
	Pooyan Khanjankhani <p.khanjankhani@digikala.com>
Subject: Re: [PATCH] revisions.txt: correct a mistake in dotted range notations section
Date: Tue, 02 May 2023 10:57:37 -0600	[thread overview]
Message-ID: <64514101af396_1ba2d294cd@chronos.notmuch> (raw)
In-Reply-To: <CAPx1GverCci3SZQEMvFX_q7r3XSTKmPizfcj8QcvGNud7reY9g@mail.gmail.com>

Chris Torek wrote:
> On Wed, Apr 26, 2023 at 1:00 AM Pooyan Khanjankhani via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
> > From: Pooyan Khanjankhani <p.khanjankhani@digikala.com>
> >
> > Insert a missing 'not' word in a negative sentence.
> >   ... but are [not] reachable from neither A or C.
> 
> There's a peculiarity of the English language here that means you
> should not use the word "not". The actual error is using "or" as
> the conjunction, instead of "nor": the construct should read
> "neither <alternative 1> nor <alternative 2>", and it means that
> both alternatives are rejected.

But it's not the same to say "not reachable from either A or C", and
"reachable from neither A nor C". In the latter if a commit is reachable
from X (or anything other than A or C), it should be included.

So A~ would be included, because it's reachable from B and reachable
from not A (i.e. B).

It should be "not reachable from either A or C".

Cheers.

-- 
Felipe Contreras

      reply	other threads:[~2023-05-02 16:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-26  7:44 [PATCH] revisions.txt: correct a mistake in dotted range notations section Pooyan Khanjankhani via GitGitGadget
2023-04-26 16:46 ` Junio C Hamano
2023-04-26 21:16 ` Chris Torek
2023-05-02 16:57   ` Felipe Contreras [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64514101af396_1ba2d294cd@chronos.notmuch \
    --to=felipe.contreras@gmail.com \
    --cc=chris.torek@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=p.khanjankhani@digikala.com \
    --cc=pooyankhan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).