From: Jeff Hostetler <git@jeffhostetler.com>
To: "Junio C Hamano" <gitster@pobox.com>,
"Jiang Xin" <worldhello.net@gmail.com>,
"Torsten Bögershausen" <tboegi@web.de>,
"Jeff Hostetler" <jeffhostetler@github.com>
Cc: "Alexander Shopov" <ash@kambanaria.org>,
"Git List" <git@vger.kernel.org>,
jmas@softcatala.org, alexhenrie24@gmail.com,
ralf.thielow@gmail.com, matthias.ruester@gmail.com,
phillip.szelat@gmail.com, vyruss@hellug.gr,
christopher.diaz.riv@gmail.com, jn.avila@free.fr,
flashcode@flashtux.org, bagasdotme@gmail.com,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
alessandro.menti@alessandromenti.it, elongbug@gmail.com,
cwryu@debian.org, uneedsihyeon@gmail.com, arek_koz@o2.pl,
dacs.git@brilhante.top, "insolor@gmail.com" <insolor@gmail.com>,
peter@softwolves.pp.se, bitigchi@me.com, ark@cho.red,
kate@kgthreads.com, "vnwildman@gmail.com" <vnwildman@gmail.com>,
pclouds@gmail.com, "dyroneteng@gmail.com" <dyroneteng@gmail.com>,
"oldsharp@gmail.com" <oldsharp@gmail.com>,
"lilydjwg@gmail.com" <lilydjwg@gmail.com>,
me@angyi.io, "pan93412@gmail.com" <pan93412@gmail.com>,
"franklin@goodhorse.idv.tw" <franklin@goodhorse.idv.tw>
Subject: Re: Is there any interest in localizing term delimiters in git messages?
Date: Thu, 19 Oct 2023 14:07:16 -0400 [thread overview]
Message-ID: <573f1142-d1de-b379-2f8b-07396c1249ec@jeffhostetler.com> (raw)
In-Reply-To: <xmqqcyxaxzxw.fsf@gitster.g>
On 10/19/23 1:52 PM, Junio C Hamano wrote:
> Jiang Xin <worldhello.net@gmail.com> writes:
>
>> I tried to find similar patterns in `po/bg.po` using:
>>
>> $ git grep -h -B5 '([a-zA-Z_\.]*_[a-zA-Z_\.]\+)' po/bg.po
>>
>> And find other translated variable names in Bulgarian as follows:
>> ...
>> I suppose it would be better to keep those variable names
>> unchanged.
>
> To me, all of them refer to names given to variables, functions, and
> mechanisms used internally as implementation details, and they are
> meant to help developers diagnose when end-users hit these errors.
>
> I agree with you that translating these would be counter-productive
> for that purpose.
>
> Having said that, I have to wonder if in an ideal world these should
> be written in terms that are more end-user facing.
>
>> * cookie_result in builtin/fsmonitor--daemon.c:
>>
>> error(_("fsmonitor: cookie_result '%d' != SEEN"),
>
> [jch: cc'ed JeffH for area expertise]
>
> For example, what does it mean to the end user when the
> cookie->result we retrieve is different from FCIR_SEEN? We lost
> sync with the fsmonitor daemon backend and to avoid yielding
> incorrect data we will be giving the "trivial" response only? It is
> not obvious from the code and b05880d3 (fsmonitor--daemon: use a
> cookie file to sync with file system, 2022-03-25) that added it why
> the end-user might even want to be shown this message [*]. I wonder
> if this should be an untranslated trace2_* message that are meant
> for debugging.
>
> Side note: and isn't the significance of the event
> "warning", not "error"? As far as the end-user is
> concerned, after emitting this message
>
> Also some of them might better be a BUG(), instead of die(_()).
...
Yeah, I think it should be an untranslated trace2 message rather
than an error. You're right, the user cannot do anything with
that information -- and by emitting a "trivial" result, we fall
back to the normal behavior and cause the client to a regular
scan. So there is no reason to scare the user.
Jeff
next prev parent reply other threads:[~2023-10-19 18:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 21:09 Is there any interest in localizing term delimiters in git messages? Alexander Shopov
2023-10-17 21:49 ` Junio C Hamano
2023-10-18 2:01 ` Jiang Xin
2023-10-18 2:47 ` Junio C Hamano
2023-10-18 3:08 ` [PATCH] commit: do not use cryptic "new_index" in end-user facing messages Junio C Hamano
2023-10-19 5:08 ` Is there any interest in localizing term delimiters in git messages? Jiang Xin
2023-10-19 17:52 ` Junio C Hamano
2023-10-19 18:07 ` Jeff Hostetler [this message]
2023-10-19 19:18 ` Junio C Hamano
2023-10-19 19:47 ` Torsten Bögershausen
2023-10-19 20:16 ` Junio C Hamano
2023-10-21 9:30 ` Peter Krefting
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573f1142-d1de-b379-2f8b-07396c1249ec@jeffhostetler.com \
--to=git@jeffhostetler.com \
--cc=alessandro.menti@alessandromenti.it \
--cc=alexhenrie24@gmail.com \
--cc=arek_koz@o2.pl \
--cc=ark@cho.red \
--cc=ash@kambanaria.org \
--cc=avarab@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=bitigchi@me.com \
--cc=christopher.diaz.riv@gmail.com \
--cc=cwryu@debian.org \
--cc=dacs.git@brilhante.top \
--cc=dyroneteng@gmail.com \
--cc=elongbug@gmail.com \
--cc=flashcode@flashtux.org \
--cc=franklin@goodhorse.idv.tw \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=insolor@gmail.com \
--cc=jeffhostetler@github.com \
--cc=jmas@softcatala.org \
--cc=jn.avila@free.fr \
--cc=kate@kgthreads.com \
--cc=lilydjwg@gmail.com \
--cc=matthias.ruester@gmail.com \
--cc=me@angyi.io \
--cc=oldsharp@gmail.com \
--cc=pan93412@gmail.com \
--cc=pclouds@gmail.com \
--cc=peter@softwolves.pp.se \
--cc=phillip.szelat@gmail.com \
--cc=ralf.thielow@gmail.com \
--cc=tboegi@web.de \
--cc=uneedsihyeon@gmail.com \
--cc=vnwildman@gmail.com \
--cc=vyruss@hellug.gr \
--cc=worldhello.net@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).